On Sat, 20 Jul 2024 06:34:36 +0100 Phil Wyett <[email protected]> wrote: > Control: tags -1 + moreinfo > > Manuel, > > Preamble... > > Thank you for taking the time to create this package and your contribution > to the Debian project. > > The review below is for assistance. This review is offered to help > package submitters to Debian mentors inorder to improve their packages > prior to possible sponsorship into Debian. There is no obligation on behalf > of the submitter to make any alterations based upon information provided > in the review. > > Review... > > 1. Build[1]: Good > > 2. Lintian[2]: Issue > > E: baby: missing-dependency-on-libc needed by usr/bin/baby > N: > N: The listed file appears to be linked against the C library, but the > N: package doesn't depend on the C library package. Normally this indicates > N: that ${shlibs:Depends} was omitted from the Depends line for this > package > N: in debian/control. > N: > N: All shared libraries and compiled binaries must be run through > N: dpkg-shlibdeps to find out any libraries they are linked against (often > N: via the dh_shlibdeps debhelper command). The package containing these > N: files must then depend on ${shlibs:Depends} in debian/control to get the > N: proper package dependencies for those libraries. > N: > N: Please refer to Generating dependencies on shared libraries (Section > N: 8.6.1) in the Debian Policy Manual for details. > N: > N: Visibility: error > N: Show-Always: no > N: Check: binaries/prerequisites > > 3. Licenses (lrc[3]): Good > > 4. Watch file (uscan --force-download): Good > > 5. Build Twice (sudo pbuilder build --twice <package>.dsc): Good > > 6. Reproducible builds (reporotest)[3]: Good > > 7. Install (No previous installs): Good > > 8. Upgrade (Over previous installs if any): N/A > > Summary... > > I believe baby is not yet ready for sponsorship/upload. Could the contributor > rectify one of more of the rasied issues. Once updated to your satisfaction > and a new upload done, please remove the 'moreinfo' on the Request For > Sponsorship (RFS) bug report.
Morning Manuel,
Right... ;-) Let's get rid of those lintian problems i.e. the ones below.
W: baby: undeclared-elf-prerequisites (libc.so.6) [usr/bin/baby]
N:
N: The installation package contains an ELF executable or object file with
N: dynamic references but does not declare any package prerequisites. The
N: Depends field in the installation control file is empty.
N:
N: This usually happens when Depends field in the source control file does
N: not mention ${shlibs:Depends} or, when not using the dh sequencer, there
N: is no call to dpkg-shlibdeps in debian/rules.
N:
N: Visibility: warning
N: Show-Always: no
N: Check: binaries/prerequisites
N: Renamed from: missing-depends-line
N:
N:
In 'debian/control'
change:
Build-Depends: debhelper-compat (= 13),
golang-any,
golang-go
to:
Build-Depends: debhelper-compat (= 13),
dh-golang,
golang-go
and also change:
Depends: ${misc:Depends}
to:
Depends: ${shlibs:Depends}, ${misc:Depends}
I: baby: unused-override statically-linked-binary
[usr/share/lintian/overrides/baby:1]
N:
N: Your package specifies the named override but there were no tags that
N: could have been silenced by it.
N:
N: Maybe you fixed an underlying condition but forgot to remove the
override.
N: It is also possible that the Lintian maintainers fixed a false positive.
N:
N: If the override is now unused, please remove it.
N:
N: This tag is similar to mismatched-override except there a tag could have
N: been silenced if the context had matched.
N:
N: Sometimes, overrides end up not being used because a tag appears only on
N: some architectures. In that case, overrides can be equipped with an
N: architecture qualifier.
N:
N: Please refer to Architecture specific overrides (Section 2.4.3) in the
N: Lintian User's Manual for details.
N:
N: Visibility: info
N: Show-Always: yes
N: Check: lintian
N:
N: 0 hints overridden; 1 unused override
Delete 'debian/baby.lintian-overrides'.
Lintian warnings other than 'Standards-Version' should be gone.
Regards
Phil
--
"I play the game for the game’s own sake"
Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans
--
Internet Relay Chat (IRC): kathenas
Website: https://kathenas.org
Instagram: https://instagram.com/kathenasorg/
Buy Me A Coffee: https://buymeacoffee.com/kathenasorg
--
signature.asc
Description: This is a digitally signed message part
