On Wed, 2024-09-04 at 13:50 +0200, Geert Stappers wrote: > Package: duck > Severity: normal > Version: not_known_by_submitter > > On Tue, Sep 03, 2024 at 09:51:25PM +0100, Phil Wyett wrote: > > On Tue, 2024-09-03 at 21:25 +0100, Peter B wrote: > > > @Phil > > > > > > Another test you could consider adding to your reviews is duck. > > > https://tracker.debian.org/pkg/duck > > > > > > Easy to run, just type duck in top of the source tree. > > > Silence indicates success. > > > > > > Its prone to false positives with "parked domains" & email addresses, > > > but works well in finding dead links, 404s, > > > and use of http instead of https > > > > > > > > > Regards, > > > Peter > > > > Peter, > > > > Thanks for putting this out there. > > And I was blunt enough to make a bugreport about it. > > > An interesting thought, but the output is mangled by the addition of ':' to > > the end of links. Makes all links 404 if you attempt to right click on them > > in a terminal and open them. > > > > Example... > > > > I: debian/copyright:62: URL: > > http://creativecommons.org/publicdomain/zero/1.0/: INFORMATION > > (Certainty:possible) > > > > The ':' is part of the link in the terminals I have tried. A solution here > > would be to replace ': ' with ' - '. > > I suggest to replace the ': ' with ' : '. > > > > I would consider using the application if some work was to be done on it. > > I know. Hence my reason to contribute to free software. > > > > Regards > > Phil > > Groeten > Geert Stappers
Hi,
Thanks for turning this into a bug report.
I'll use your suggestion " : " for now. Quite a trivial change in git.
diff --git a/src/duck b/src/duck
index 72ed95b..2183626 100755
--- a/src/duck
+++ b/src/duck
@@ -317,7 +317,7 @@ foreach my $entry (@entries) {
}
if ($opt{n}) {
- print STDOUT $type . ": " . $k . ": " . $url . ": ";
+ print STDOUT $type . ": " . $k . ": " . $url . " : ";
print STDOUT " DRY RUN\n";
next;
}
@@ -513,7 +513,7 @@ sub display_result($;$;$) {
}
if ($data->{url}) {
- $out .= $data->{url} . ": ";
+ $out .= $data->{url} . " : ";
}
$res->{retval} = 2 unless $res->{retval} < 2;
Regards
Phil
--
"I play the game for the game’s own sake"
Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans
--
Buy Me A Coffee: https://buymeacoffee.com/kathenasorg
Internet Relay Chat (IRC): kathenas
Matrix: #kathenas:matrix.org
Website: https://kathenas.org
Instagram: https://instagram.com/kathenasorg/
Threads: https://www.threads.net/@kathenasorg
--
signature.asc
Description: This is a digitally signed message part
