Hi Phil,

re: the two issues you raised:

2. Standards version fixed.
5. Build twice issue fixed.

Colin


On 23/10/2024 23:22, Phil Wyett wrote:
Control: tags -1 +moreinfo

Colin,

Preamble...

Thank you for taking the time to prepare this package and your contribution
to the Debian project.

The review below is for assistance. This review is offered to help package
submitters to Debian mentors inorder to improve their packages prior to
possible sponsorship into Debian. There is no obligation on behalf of the
submitter to make any alterations based upon information provided in the
review.

Review...

1. Build:

   * pbuilder [1]: Good
   * sbuild [2]: Good

2. Lintian [3]: Issue

W: qatzip source: newer-standards-version 4.7.2 (current is 4.7.0)
N:
N:   The source package refers to a Standards-Version which is newer than the
N:   highest one Lintian is programmed to check.
N:
N:   If the source package is correct, please upgrade Lintian to the newest
N:   version.
N:
N:   Visibility: warning
N:   Show-Always: no
N:   Check: fields/standards-version

3. Licenses [4]: Good

4. Watch file [uscan --force-download]: Good

5. Build Twice [sudo pbuilder build --twice <package>.dsc]: Issue

  dpkg-source --before-build .
  debian/rules clean
dh clean
    debian/rules override_dh_auto_clean
make[1]: Entering directory '/build/qatzip-1.2.0'
:
make[1]: Leaving directory '/build/qatzip-1.2.0'
    dh_autoreconf_clean
    dh_clean
  dpkg-source -b .
dpkg-source: info: using source format '3.0 (quilt)'
dpkg-source: info: building qatzip using existing ./qatzip_1.2.0.orig.tar.gz
dpkg-source: info: using patch list from debian/patches/series
dpkg-source: error: cannot represent change to src/.libs/libqatzip.so:
dpkg-source: error:   new version is symlink to libqatzip.so.3.0.3
dpkg-source: error:   old version is nonexistent
dpkg-source: error: cannot represent change to src/.libs/libqatzip.la:
dpkg-source: error:   new version is symlink to ../libqatzip.la
dpkg-source: error:   old version is nonexistent
dpkg-source: error: cannot represent change to src/.libs/libqatzip.so.3:
dpkg-source: error:   new version is symlink to libqatzip.so.3.0.3
dpkg-source: error:   old version is nonexistent
dpkg-source: warning: executable mode 0755 of 'config.status' will not be
represented in diff
dpkg-source: warning: executable mode 0755 of 'libtool' will not be
represented in diff
dpkg-source: error: cannot represent change to src/.libs/libqatzip.a: binary
file contents changed
dpkg-source: error: add src/.libs/libqatzip.a in debian/source/include-
binaries if you want to store the modified binary in the debian tarball
dpkg-source: error: cannot represent change to src/.libs/libqatzip.so.3.0.3:
binary file contents changed
dpkg-source: error: add src/.libs/libqatzip.so.3.0.3 in
debian/source/include-binaries if you want to store the modified binary in
the debian tarball
dpkg-source: warning: executable mode 0755 of 'src/.libs/libqatzip.so.3.0.3'
will not be represented in diff
dpkg-source: error: cannot represent change to src/.libs/libqatzip_la-
qatzip.o: binary file contents changed
dpkg-source: error: add src/.libs/libqatzip_la-qatzip.o in
debian/source/include-binaries if you want to store the modified binary in
the debian tarball
dpkg-source: error: cannot represent change to src/.libs/libqatzip_la-
qatzip_counter.o: binary file contents changed
dpkg-source: error: add src/.libs/libqatzip_la-qatzip_counter.o in
debian/source/include-binaries if you want to store the modified binary in
the debian tarball
dpkg-source: error: cannot represent change to src/.libs/libqatzip_la-
qatzip_gzip.o: binary file contents changed
dpkg-source: error: add src/.libs/libqatzip_la-qatzip_gzip.o in
debian/source/include-binaries if you want to store the modified binary in
the debian tarball
dpkg-source: error: cannot represent change to src/.libs/libqatzip_la-
qatzip_lz4.o: binary file contents changed
dpkg-source: error: add src/.libs/libqatzip_la-qatzip_lz4.o in
debian/source/include-binaries if you want to store the modified binary in
the debian tarball
dpkg-source: error: cannot represent change to src/.libs/libqatzip_la-
qatzip_mem.o: binary file contents changed
dpkg-source: error: add src/.libs/libqatzip_la-qatzip_mem.o in
debian/source/include-binaries if you want to store the modified binary in
the debian tarball
dpkg-source: error: cannot represent change to src/.libs/libqatzip_la-
qatzip_stream.o: binary file contents changed
dpkg-source: error: add src/.libs/libqatzip_la-qatzip_stream.o in
debian/source/include-binaries if you want to store the modified binary in
the debian tarball
dpkg-source: error: cannot represent change to src/.libs/libqatzip_la-
qatzip_sw.o: binary file contents changed
dpkg-source: error: add src/.libs/libqatzip_la-qatzip_sw.o in
debian/source/include-binaries if you want to store the modified binary in
the debian tarball
dpkg-source: error: cannot represent change to src/.libs/libqatzip_la-
qatzip_utils.o: binary file contents changed
dpkg-source: error: add src/.libs/libqatzip_la-qatzip_utils.o in
debian/source/include-binaries if you want to store the modified binary in
the debian tarball
dpkg-source: error: cannot represent change to src/.libs/libqatzip_la-
xxhash.o: binary file contents changed
dpkg-source: error: add src/.libs/libqatzip_la-xxhash.o in
debian/source/include-binaries if you want to store the modified binary in
the debian tarball
dpkg-source: error: cannot represent change to src/libqatzip_la-qatzip.o:
binary file contents changed
dpkg-source: error: add src/libqatzip_la-qatzip.o in debian/source/include-
binaries if you want to store the modified binary in the debian tarball
dpkg-source: error: cannot represent change to src/libqatzip_la-
qatzip_counter.o: binary file contents changed
dpkg-source: error: add src/libqatzip_la-qatzip_counter.o in
debian/source/include-binaries if you want to store the modified binary in
the debian tarball
dpkg-source: error: cannot represent change to src/libqatzip_la-
qatzip_gzip.o: binary file contents changed
dpkg-source: error: add src/libqatzip_la-qatzip_gzip.o in
debian/source/include-binaries if you want to store the modified binary in
the debian tarball
dpkg-source: error: cannot represent change to src/libqatzip_la-qatzip_lz4.o:
binary file contents changed
dpkg-source: error: add src/libqatzip_la-qatzip_lz4.o in
debian/source/include-binaries if you want to store the modified binary in
the debian tarball
dpkg-source: error: cannot represent change to src/libqatzip_la-qatzip_mem.o:
binary file contents changed
dpkg-source: error: add src/libqatzip_la-qatzip_mem.o in
debian/source/include-binaries if you want to store the modified binary in
the debian tarball
dpkg-source: error: cannot represent change to src/libqatzip_la-
qatzip_stream.o: binary file contents changed
dpkg-source: error: add src/libqatzip_la-qatzip_stream.o in
debian/source/include-binaries if you want to store the modified binary in
the debian tarball
dpkg-source: error: cannot represent change to src/libqatzip_la-qatzip_sw.o:
binary file contents changed
dpkg-source: error: add src/libqatzip_la-qatzip_sw.o in
debian/source/include-binaries if you want to store the modified binary in
the debian tarball
dpkg-source: error: cannot represent change to src/libqatzip_la-
qatzip_utils.o: binary file contents changed
dpkg-source: error: add src/libqatzip_la-qatzip_utils.o in
debian/source/include-binaries if you want to store the modified binary in
the debian tarball
dpkg-source: error: cannot represent change to src/libqatzip_la-xxhash.o:
binary file contents changed
dpkg-source: error: add src/libqatzip_la-xxhash.o in debian/source/include-
binaries if you want to store the modified binary in the debian tarball
dpkg-source: error: cannot represent change to test/bt: binary file contents
changed
dpkg-source: error: add test/bt in debian/source/include-binaries if you want
to store the modified binary in the debian tarball
dpkg-source: warning: executable mode 0755 of 'test/bt' will not be
represented in diff
dpkg-source: error: cannot represent change to test/bt-bt.o: binary file
contents changed
dpkg-source: error: add test/bt-bt.o in debian/source/include-binaries if you
want to store the modified binary in the debian tarball
dpkg-source: error: cannot represent change to test/qatzip-test: binary file
contents changed
dpkg-source: error: add test/qatzip-test in debian/source/include-binaries if
you want to store the modified binary in the debian tarball
dpkg-source: warning: executable mode 0755 of 'test/qatzip-test' will not be
represented in diff
dpkg-source: error: cannot represent change to test/qatzip_test-main.o:
binary file contents changed
dpkg-source: error: add test/qatzip_test-main.o in debian/source/include-
binaries if you want to store the modified binary in the debian tarball
dpkg-source: error: cannot represent change to utils/qzip: binary file
contents changed
dpkg-source: error: add utils/qzip in debian/source/include-binaries if you
want to store the modified binary in the debian tarball
dpkg-source: warning: executable mode 0755 of 'utils/qzip' will not be
represented in diff
dpkg-source: error: cannot represent change to utils/qzip-qzip.o: binary file
contents changed
dpkg-source: error: add utils/qzip-qzip.o in debian/source/include-binaries
if you want to store the modified binary in the debian tarball
dpkg-source: error: cannot represent change to utils/qzip-qzip_7z.o: binary
file contents changed
dpkg-source: error: add utils/qzip-qzip_7z.o in debian/source/include-
binaries if you want to store the modified binary in the debian tarball
dpkg-source: error: cannot represent change to utils/qzip-qzip_main.o: binary
file contents changed
dpkg-source: error: add utils/qzip-qzip_main.o in debian/source/include-
binaries if you want to store the modified binary in the debian tarball
dpkg-source: error: unrepresentable changes to source
dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 1
I: copying local configuration
E: Failed autobuilding of package
I: unmounting dev/ptmx filesystem
I: unmounting dev/pts filesystem
I: unmounting dev/shm filesystem
I: unmounting proc filesystem
I: unmounting sys filesystem
I: cleaning the build env
I: removing directory /var/cache/pbuilder/build/3434 and its subdirectories

6. Reproducible builds [5]: Good

7. Install [No previous installs]: Good

8. Upgrade [Over previous installs if any]: N/A

Summary...

I believe qatzip is not yet ready for sponsorship at this time. Could the
contributor rectify one of more of the raised issues.

Once updated to your satisfaction and a new upload done, please remove the
'moreinfo' tag on the Request For Sponsorship (RFS) bug report.

Regards

Phil

[1] pbuilder:

   * Command: sudo pbuilder build <PACKAGE>.dsc
   * Document: https://wiki.ubuntu.com/PbuilderHowto.
   * Document: https://wiki.debian.org/PbuilderTricks

[2] sbuild:

   * Command: sbuild <PACKAGE>.dsc
   * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000002
   * Document: https://wiki.debian.org/sbuild

[3] lintian:

   * Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc,
*.changes, *.buildinfo). Each can throw up different results, so be thorough.
   * Document: https://wiki.debian.org/Lintian

[4] lrc:

   * Command: lrc
   * Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon

[5] reprotest

   * Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto-
build <PACKAGE>.dsc -- schroot unstable-amd64-sbuild
   * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000004
   * Document: https://wiki.debian.org/ReproducibleBuilds/
   * Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method


Reply via email to