Hi Phil, > Control: tags -1 +moreinfo > > Xiyue, > > Merry Christmas mate. >
Merry belated Christmas!
> Preamble...
>
> Thank you for taking the time to prepare this package and your contribution to
> the Debian project.
>
> The review below is for assistance. This review is offered to help package
> submitters to Debian mentors inorder to improve their packages prior to
> possible sponsorship into Debian. There is no obligation on behalf of the
> submitter to make any alterations based upon information provided in the
> review.
>
> Review...
>
> 1. Build:
>
> * pbuilder [1]: Good
> * sbuild [2]: Good
>
> 2. Lintian [3]: Issue
>
> Running lintian...
> N:
> N: Upstream description uses first person tone.
> O: elpa-tp: using-first-person-in-description line 14: We
> N:
> N: You should avoid the use of first person ("I will do this..." or "We
> N: recommend..."). The computer is not a person and the description does not
> N: speak for the maintainer or maintainers. Instead, use a more neutral
> N: construction and try to rephrase into factual statements about the
> N: package.
> N:
> N: For example, rather than saying "I don't recommend this package if you
> are
> N: short on memory," say something like "this package is not suitable for
> N: low-memory systems."
> N:
> N: Visibility: info
> N: Show-Always: no
> N: Check: fields/description
> N:
> N:
> N: Upstream description uses first person tone.
> O: elpa-tp: using-first-person-in-description line 15: our
> N:
> N: Upstream description uses first person tone.
> O: elpa-tp: using-first-person-in-description line 16: We
> N:
> N: Upstream description uses first person tone.
> O: elpa-tp: using-first-person-in-description line 18: We
> N:
> N: Upstream description uses first person tone.
> O: elpa-tp: using-first-person-in-description line 20: we
> N:
> N: Upstream description uses first person tone.
> O: elpa-tp: using-first-person-in-description line 22: We
> N:
> N: Upstream description uses first person tone.
> O: elpa-tp: using-first-person-in-description line 24: We
> N:
> N: Upstream description uses first person tone.
> O: elpa-tp: using-first-person-in-description line 25: We
>
> I: Lintian run was successful.
>
> We can fix this and not override can't we?
>
Not being a native speaker, I kinda prefer using the upstream
description as-is. But apparently this is also suggested in the
developer guide, so I have replaced them with 3rd-person tone. Salsa
and mentors updated. PTAL.
P.S. I seem to be having trouble to receive your mail in this Gmail
account. It was not until I checked the RFS bug directly until I saw
your package review (also check my spam folder and none found there
either). Is there anyway to check where and how your mail could have
been dropped?
--
Regards,
Xiyue Deng
signature.asc
Description: PGP signature
