Control: tags -1 -moreinfo Hi Phil,
Thank you for another review. > The file highlighted is one you remove via the patch listed below. > > 'd/patches/arch-indep.patch' > > This file highlishted now does not need to be in 'd/copyright'. > > I would suggest exploring removal of this and other files in the above > mentioned patch via the 'Files-Excluded' mechanism. > > https://wiki.debian.org/UscanEnhancements The background is that I cleaned up my patch for sending to upstream and that involved adding removal of those two files since they're unused after the changes. I thought it nice to make the patch be the exact same as the one I sent upstream. But since Debian Policy 6.8.8.2. strongly recommends using upstream sources as-is I've instead removed the removal of these two files from the patch I include in the Debian packaging code. Since I'm also using a full Git-based packaging approach as per DEP-14 it's unclear to me how Files-Excluded would work for me. gbp seems to have support for it only when using import-orig, which isn't the setup I'm using. Removing upstream files in a packaging commit doesn't seem like the way to go either. So I've just sidestepped this for now since not having to repack seems more proper anyway. Note: even if I kept the removal in the patch and didn't go with Files-Excluded it seems I'd instead have to licence my patch as MIT since it'd include the removed MIT-licensed code verbatim. Raul
