Control: tags -1 -moreinfo Thank you Jeroen for doing the review. I have incorporated the recommendations with upload.
Regards, Syed Shahrukh Hussain. On Thu, Sep 25, 2025 at 1:46 PM Jeroen Ploemen <[email protected]> wrote: > Control: tags -1 moreinfo > > On Tue, 23 Sep 2025 01:46:54 +0500 > Syed Shahrukh <[email protected]> wrote: > > > I am looking for a sponsor for my package "cramfsswap": > > hi Syed, > > please push your changes to the package's git repo on salsa, you have > been granted access. > > Nice idea to add an autopkgtest. You should add a further check to > verify the intermediate file (after the first swap) actually differs > from the original; otherwise, the autopkgtest could succeed even if > cramfsswap did not perform any action at all due to a bug. > > As a further improvement, you could use the 'file' utility to print > information about the cramfs files before and after the swaps; it > nicely displays the endianness of the file. > > > Please remove the moreinfo tag (and CC me) once you have an updated > package ready. >
