On 28/09/25 11:28, Charlie Yan wrote:
The upstream is in salsa here <https://salsa.debian.org/python-team/packages/python-eventdispatch>, my error in the RFS bug using the wrong link

Is it fair to say the next step is to fix all the comments you have, as well as the QA issues, then file another RFS bug?

Thank you Aryan for your guidance (and patience)

Yes, I only covered a few of the format errors but there's a lot of issues with the packaging. It's better to use dh_make [1] to generate the debian/ folder and edit the template (check the previous links for reference) and sbuild [2] to build the package in a minimal chroot environment which uses Debian unstable. Go for a fresh packaging I'd say.

You should also learn about which release you need to target whether experimental or unstable. Trixie isn't a branch that you can upload your package to. Refer [3]

No, you don't need to file a new RFS bug. Just reply to this bug email with the control commands i mentioned once you fix the packaging.

[1] https://manpages.debian.org/testing/dh-make/dh_make.1.en.html

[2] https://wiki.debian.org/sbuild

[3] https://www.debian.org/doc/debian-policy/ch-source.html#debian-changelog-debian-changelog



On Sat, Sep 27, 2025, 8:40 PM Aryan Karamtoth <[email protected]> wrote:

    Control: tags -1 +moreinfo

    Hi,

    Here's the review like I mentioned in #debian-python

    Firstly I highly recommend you to move your repository to Debian
    Salsa
    under Debian Python Team to make it easier for your sponsors to
    make any
    fixes. Github makes it difficult to work with.

    In debian/rules,

    export PYBUILD_NAME = random-quote

    It should be renamed to whatever package that your package is
    installing, in this case it is eventdispatch

    You're also missing d/upstream/metadata, please refer to one of my
    metadata files for reference [1] and add it back

    Your d/changelog is also in the wrong format

    Versioning of the package must be the same as upstream. For
    example, if
    the upstream version is 3.4.0, the debian package version should be
    3.4.0-1 and once your package gets uploaded to debian but you need
    some
    fixes in the debian folder, you make a new update for 3.4.0-2.

    Your d/changelog also needs to close the ITP bug, refer to this
    [2] for
    example

    I cannot go any deeper than this as the entire packaging is
    riddled with
    errors. Consider using sbuild to build your packages as it makes it
    easier to detect lintian errors. Using dh_make will generate a
    pre-made
    debian folder template for you that you can easily edit.

    https://mentors.debian.net/package/python-eventdispatch/

    Also a lot of errors reported by Debian QA on mentors. Refer to the
    debian docs and I recommend going for a fresh packaging with the
    tools I
    mentioned as this one is entirely messed up.

    Remove the moreinfo tag using "Control: tags -1 -moreinfo" once
    you fix
    all of the errors.

    To give you a better idea of what a python library debian folder
    should
    look like, have a look at one of my recent packages [3].


    [1]
    
https://salsa.debian.org/python-team/packages/python-resample/-/blob/debian/latest/debian/upstream/metadata?ref_type=heads

    [2]
    
https://salsa.debian.org/python-team/packages/python-resample/-/blob/debian/latest/debian/changelog?ref_type=heads

    [3]
    
https://salsa.debian.org/python-team/packages/python-resample/-/tree/debian/latest/debian?ref_type=heads

-- Regards,

    Aryan Karamtoth
    Matrix: @SpaciousCoder78:matrix.org <http://matrix.org>
    XMPP: [email protected]

    GPG Fingerprint: 7A7D 9308 2BD1 9BAF A83B 7E34 FE90 07B8 ED64 0421

--
Regards,

Aryan Karamtoth
Matrix: @SpaciousCoder78:matrix.org
XMPP:[email protected]

GPG Fingerprint: 7A7D 9308 2BD1 9BAF A83B 7E34 FE90 07B8 ED64 0421

Attachment: OpenPGP_0xFE9007B8ED640421.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature

Reply via email to