Control: tags -1 -moreinfo Hi, Thanks a lot for taking the time to review the package and provide feedback. https://mentors.debian.net/package/open-vmdk/
I uploaded a new version of the package and addressed the points you suggested, including retitling the RFP to ITP and merging, applying the recommended hardening flags, and updating other minor packaging details. Please let me know if you spot anything else. Regards, Mégane Vilain. On Sat, Oct 4, 2025 at 1:02 PM Jeroen Ploemen <[email protected]> wrote: > Control: tags -1 moreinfo > > On Fri, 12 Sep 2025 00:52:39 +0200 > mégane Vilain <[email protected]> wrote: > > > I am looking for a sponsor for my package open-vmdk: > > hi mégane, > > I reviewed the open-vmdk package, see my comments and suggestions for > improvement below. Don't be discouraged, most of it is fairly trivial > to fix: > > * RFP/ITP bugs should be merged; the usual workflow when packaging > something for which an RFP is open is to retitle that bug to an ITP > and take ownership. See the 'bts' command and/or > https://www.debian.org/Bugs/server-control > > * copyright: years for upstream VMware, Inc. are given as 2011-2025, > but claimed years in the upstream sources for that copyright holder > do not extend beyond 2023. > > * copyright: missing info for: > pytest/conftest.py:1:# Copyright (c) 2024 Broadcom. All Rights Reserved. > pytest/test_envelope_configs.py:1:# Copyright (c) 2024 Broadcom. All > Rights Reserved. > pytest/test_options.py:1:# Copyright (c) 2024 Broadcom, Inc. All Rights > Reserved. > pytest/test_info_options.py:1:# Copyright (c) 2025 Broadcom. All Rights > Reserved. > pytest/test_raw_image_option.py:1:# Copyright (c) 2024 Broadcom. All > Rights Reserved. > pytest/test_vmdk.py:1:# Copyright (c) 2025 Broadcom. All Rights > Reserved. > pytest/test_all_configs.py:1:# Copyright (c) 2024 Broadcom. All Rights > Reserved. > > * copyright: it appears you wrote manpages for several of the utils > (excellent!). Yet in those manpages, the author is listed as 'the > VMware open-vmdk team' and copyright assigned to 'VMware, Inc.'. > > If that company really holds the copyright (for example because > they are your employer), you should correct d/copyright by adding > an entry for these manpages. If not, why not accurately list the > author as yourself (e.g. 'written by <you> for the debian project') > and similar for the copyright part? > > * control: VCS links should point to the repository holding the > Debian packaging, which is typically separate from the one used for > the upstream code. > > Consider using salsa.debian.org as VCS, which comes with a nice > Debian-focused CI workflow and is open to all contributors (not > just certified Debian developers). Note that accounts are subject > to manual approval to prevent abuse; with a freemail address it can > sometimes be helpful to make yourself and the reason for applying > for an account known on IRC (#salsa on the OFTC network). > > * install: please use dh_installman (via d/manpages) to install > manpage files, rather than the generic dh_install; examples > similarly should be handled by dh_installexamples (via d/examples). > > * Any chance to put the upstream testsuite (under ./pytest) to good > use, by running it on build and/or as an autopkgtest? > > * rules: no hardening? See https://wiki.debian.org/Hardening > Setting 'export DEB_BUILD_MAINT_OPTIONS = hardening=+all' in > d/rules is usually enough. If hardening options are used during > build but lintian still nags about it, feel free to add an override. > > * Missing manpages for multiple utils/scripts installed into /usr/bin. > > * Various lintian hits: > E: open-vmdk: script-uses-unversioned-python-in-shebang [usr/bin/ovfenv]. > You may want to use a debhelper plugin to auto-correct the shebang. For > Python, this can be as simple as adding a build-dependency on > dh-sequence-python3, and a ${python3:Depends} macro in the > dependencies for the binary package (replacing the current > 'python3' dependency). > > W: open-vmdk: script-with-language-extension [usr/bin/mkova.sh] > > W: open-vmdk: groff-message 32: warning: macro '..' not defined > [usr/share/man/man1/vmdk-convert.1.gz:1] > > > Please remove the moreinfo tag (and CC me) once you have an updated > package ready. >
