Hi Pierre, Jérémy, Thank you both for your review and helpful suggestions!
Let me address the points you raised and let me know if they are answered with this: 1. On the Node.js binary (third_party/node/linux/node-linux-x64/bin/node) Good catch on this! This package already uses system Node.js from the Debian nodejs package instead of any bundled binary: - nodejs is listed in Build-Depends - debian/rules creates a symlink: ln -sf /usr/bin/node .../third_party/node/.../node - Patch 0013-skip-nodejs-version-check.chromium.patch bypasses the version check (system node v20.x vs expected v22.x) However, I've added it explicitly to debian/copyright Files-Excluded for documentation: chromium/third_party/node/linux/* Is that what you meant? 2. On debian/watch format and component support (Jérémy) Thank you for the suggestion! I've converted debian/watch to Version 5 format (RFC822-style) which is indeed more readable. I have added comments in each section to explain why we track what we track. Note: We depend on DEBIAN's chromium package (not upstream Google), this is until Chromium Team releases a source package, so the chromium component tracks deb.debian.org/debian/pool/main/c/chromium/. Version: 5 Mode: git Source: https://bitbucket.org/chromiumembedded/cef.git Matching-Pattern: refs/tags/(\d+\.\d+\.\d+) Pgp-Mode: none Component: chromium Source: https://deb.debian.org/debian/pool/main/c/chromium/ Matching-Pattern: chromium_(@ANY_VERSION@)\.orig\.tar\.xz ... Component: depot-tools Mode: git Git-Mode: shallow Source: https://chromium.googlesource.com/chromium/tools/depot_tools.git ... 3. On other precompiled binaries in third_party (Jérémy) I've investigated the tarballs thoroughly. The chromium component tarball is derived from Debian's chromium source which already has extensive Files-Excluded applied. My analysis found: - No .so binaries (only .so.c source files) - No .jar, .wasm files - No third_party/node/linux/ directory (already excluded by Debian chromium) - No buildtools directory (already excluded by Debian chromium) The "binary-looking" files that remain are actually: - Shell/Python scripts (ninja, cipd, siso in depot-tools) - Test data files (*.bin fuzzer seeds - not executables) For system replacements beyond node, debian/rules also handles: - Rollup: symlinks /usr/share/nodejs/rollup to replace bundled @rollup/wasm-node I'm happy to add more explicit exclusions to debian/copyright if you think that would improve documentation clarity, even though the base tarball from Debian chromium already excludes them. 4. On contacting the Chromium team Understood - I'll reach out to the Debian Chromium maintainers before we proceed with any upload to make them aware of this package. Jérémy, please feel free to suggest any additional improvements to the watch file format - I appreciate any feedback. All these changes are now in salsa: https://salsa.debian.org/mendezr/chromium-embedded-framework Best regards, Juan PS: Currently working on being up to date with the latest debian chromium released today.
