Control: tags -1 moreinfo Control: retitle -1 RFS: instant-remote-storage/4.2.0-6 [ITP] -- Automatic remote storage uploader with MIME-based renaming
Hi Carlo, There are *upstream* integration issues, I fear instant-remote-storage is at the moment not yet ready to be included into Debian. needs to improve first before it should be added to Debian. Let me give you a brief review, it is certainly not complete. (review based on mentor upload #8 dated 2025-10-06 02:57) d/changelog The initial upload to Debian has just one line, something like "Initial upload. (Closes: #ITP). (uploads happened outside of Debian are not of interest, also d/changelog is only for the packaging, generally upstream changes are not mentioned, except they are very notworthy) d/irs-setup It looks like this is some setup tool; it seems to modify/create configuration in /etc/…, but for a specific user. This seems wrong, this is not how services should be configured configured. A global configuration that is user specific does not make sense as Debian is designed as a multiuser system. Should this be reworked in favour of user (systemd) units? Since the mainscript is hardcoding paths to /etc, note that a regular user does not have write access there. The lockfile is hardcoded filename to /tmp. This allows everyone on the system do DoS a user, if they want to; if two users simulantous using your took, this won't work. Also, the admin can DoS users by the lookup priorities of the configuration files. Your paths should follow XDG Base Directory Specification, not hardcode paths. d/install - mentions README.Debian, but there is no such file. - it is recommended to name it $PACKAGENAME.install - shell scripts should not have the .sh extension when installed via a package. the main script On Tue, 09 Sep 2025 00:46:33 +0200 Carlo Capobianchi <[email protected]> wrote: > Package: sponsorship-requests > Severity: wishlist > X-Debbugs-Cc: [email protected], [email protected] > > RFS: instant-remote-storage/3.0.0-12 [ITP #1114689] -- Automatic remote storage uploader with MIME-based renaming > > Dear mentors, > > I am looking for a sponsor for my package "instant-remote-storage". > > * Package name : instant-remote-storage > * Version : 3.0.0-12 > * Upstream contact: Carlo Capobianchi <[email protected]> > * License : Expat (MIT-like) > * Vcs : https://github.com/bynflow/instant-remote-storage.git > * Homepage : https://github.com/bynflow/instant-remote-storage > * ITP : #1114689 > > It builds these binary packages: > instant-remote-storage - Automatic remote storage uploader with MIME-based renaming > > Mentors page: > https://mentors.debian.net/package/instant-remote-storage/ > > dget: > dget -x https://mentors.debian.net/debian/pool/main/i/instant-remote-storage/instant-remote-storage_3.0.0-12.dsc > > Changes since the last upload: > * Initial upload to Debian. Standards-Version: 4.6.2; debhelper- compat: 13. > * Systemd templated unit, manpages, wrapper and setup helper. > * Depends: rclone, inotify-tools, file; Recommends: xdg-utils. > > Regards, > -- Carlo Capobianchi > >
