Hi,

(seems you didn't remove the moreinfo flag to indicate this is ready
for review, but after looking at the updated package, I think moreinfo
is still needed.)

However, the nmudiff is huge... Is this really the minimal fix for
#1123467? 

NMUing a new upstream release is *usually* out of scope, we want
targeted fixes, especially if there is no explaining why this is
needed. Not-minimal (or even new upstream releases) NMUs can happen but
requires some extra amount of reasoning, e.g in d/changelog and
possibly here in this RFS bug.

The package has reverse dependencies, some information about whether
you've checked those and that they will still work with the new version
would be helpful too.

The new upstream releases changes copyright information, but your NMU
does not update d/copyright.

Diff the archive and your dsc gives undocumented changes, (e.g
gbg.cong) even a unwanted (although whitespace) change in d/changelog.

I'd rather not re-enable the watch file in an NMU.

"I recommend to limit yourself to release-critical bugs for NMUs" 'd be
still is my recommendation.


--
tobi

Reply via email to