Hi Damian
On Thu, Jul 30, 2026 at 01:11:32PM +0000, [email protected] wrote: > Package: sponsorship-requests > Severity: normal > > Dear mentors, > > I am looking for a sponsor for my package "scenefx": > > * Package name : scenefx > Version : 0.5-1 > Upstream Author : wlrfx > * URL : https://github.com/wlrfx/scenefx (https://github.com/wlrfx/scenefx) > * License : MIT (tinywl/ example subdirectory: CC0-1.0) > Section : libs > > This closes the ITP bug: https://bugs.debian.org/1143103 > (https://bugs.debian.org/1143103) > > It builds those binary packages: > > libscenefx-0.5-0 - wlroots scene API with eye-candy effects (shared library) > libscenefx-0.5-dev - wlroots scene API with eye-candy effects (development > files) > > To access further information about this package, please visit the > following URL: > > https://salsa.debian.org/damian/scenefx > (https://salsa.debian.org/damian/scenefx) > > Alternatively, one can download the package with dget using this command: > > dget -x > https://mentors.debian.net/debian/pool/main/s/scenefx/scenefx_0.5-1.dsc > (https://mentors.debian.net/debian/pool/main/s/scenefx/scenefx_0.5-1.dsc) > > More information about scenefx can be obtained from > https://github.com/wlrfx/scenefx (https://github.com/wlrfx/scenefx). > > Changes since the last upload: > > Initial release. (Closes: #1143103) a short review: - tinywl seems to be an embedded code library; nick's approach was to remove it (repacking the source package), that seems to be indicating that it is not used. Can you check if it is needed? If it is not used, you can also remove it using d/clean, so that it won't be used in the build - or you repack. If it is needed, it probably should be packaged separatly. - d/copyright - "MIT" should be called "Expat" - The Comment for the MIT section is not needed, as we verbatimely document what upstream states in the source code. - There is an extra "not" in: "The full license text is not included here since it is __not__ part of /usr/share/common-licenses; see…" that negates the inteneded meaning. Said that, a better wording (as more standard) would be anyway something like: "On Debian systems, the full text of the Creative Commons Zero can be found in /usr/share/common-licenses/CC0-1.0" - d/control: - don't specify version constraints on your BD, if they are fulfilled already since oldstable. - Stand-Version is usally only given with 3 digitt, not 4. - Rules-Requires-Root is obsolete, remove it. - d/changelog should be a single line (Intial Release …), although I appreciate you've added Nick as uploader, you still should have only one entry in d/changelog. - d/*.install use ${DEB_HOST_MULTIARCH} for the multiarch path, instead of the wildcard "*" - should the examples be installed with dh_installexamples(1), maybe to the -dev package? W: libscenefx-0.5: lacks-unversioned-link-to-shared-library example: usr/lib/x86_64-linux-gnu/libscenefx.so [usr/lib/x86_64-linux-gnu/libscenefx-0.5.so] seems to indicate that there is something odd in regards to the SONAME of th library. can you check? Cheers, -- tobi
