Hi Jeroen,

Thanks for the review.

* changelog: no need to repeat the bug title or summary when closing
   a bug, just the bug number will do.

Updated d/changelog.

* copyright: missing entry for:
   petl/io/xlutils_view.py:2:# Copyright (c) 2013 Simplistix Ltd

Updated d/copyright.

* control: the short description on the binary package used to
   reference the field in the Source stanza (via Description:
   ${source:Synopsis}), but no longer does. Instead, there are now
   separate description fields (with slightly different content) for
   the source and binary pkg. That duplication doesn't serve a
   purpose, especially for a simple single-binary package.

Updated d/control, which restores the lines to when before I took over.

* rules: [already fixed in git] no tests were run on build at all,
   although the upstream testsuite can be successfully run with only
   minor packaging tweaks.

Thank you.

* control: I suspect more build-deps could be marked '<!nocheck>'?

I marked more packages with nocheck.

* the upstream testsuite get installed into the binary package, is
   that intentional? Is it used somehow by a reverse dependency?

I have excluded them in the binary package.

Please remove the moreinfo tag (and CC me) once you have an updated
package ready.

Done, I have also updated the package to 1.7.24.

Thanks!

--
Regards,
Lester

[email protected]
OpenPGP: 107B6026A82D044C97D7D8B92100C145E0F3655E


Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature

Reply via email to