Control: tags -1 + moreinfo Hi!
I looked at the orig source tarball and I think the software is in good shape,
probably. Being said, I don't have much experience in qt, cmake, or C++.
A few places in the debian packaging that may be improved:
Where do you plan to put the debian packaging? If not Salsa, there are other
places, even gitlab.trisquel.org is ok (but not the most ideal). Anyway, this
will need to be reflected in Vcs-Git and Vcs-Browser field in d/control.
A very pedantic note: in d/copyright, the DEP-5 format to say GPL 3.0 or later
should be "GPL-3+", not "GPL-3.0-or-later".
-------------8<-------------8<-----------
$ lintian --pedantic -EIiv trizbort-qt_1.0-1.dsc
N:
I: trizbort-qt source: older-debian-watch-file-standard 4 [debian/watch]
N:
N: The version= line in the debian/watch file in this package declares an
older version. Please upgrade when you have a chance.
N:
N: Please refer to the uscan(1) manual page for details.
N:
N: Visibility: info
N: Show-Always: no
N: Check: debian/watch/standard
N:
N:
P: trizbort-qt source: package-uses-old-debhelper-compat-version 13
N:
N: This package uses a debhelper compatibility level that is no longer
recommended. Please consider using the recommended level.
N:
N: For most packages, the best way to set the compatibility level is to
specify debhelper-compat (= X) as a Build-Depends in debian/control. You can
also use the debian/compat file or export DH_COMPAT in debian/rules.
N:
N: If no level is selected debhelper defaults to level 1, which is deprecated.
N:
N: Please refer to the debhelper(7) manual page for details.
N:
N: Visibility: pedantic
N: Show-Always: no
N: Check: debhelper
N:
N:
P: trizbort-qt source: redundant-priority-optional-field [debian/control:3]
N:
N: This package currently sets the Priority field in the debian/control file
to "optional".
N:
N: As of dpkg version 1.22.13, this field is set to "optional" by default. As
such, in this case the Priority field is redundant and should be removed.
N:
N: Visibility: pedantic
N: Show-Always: no
N: Check: debian/control/field/priority
N:
N:
P: trizbort-qt source: redundant-rules-requires-root-no-field
[debian/control:11]
N:
N: This package currently sets the Rules-Requires-Root field in the
debian/control file to "no".
N:
N: As of dpkg version 1.22.13, this field is set to "no" by default. As such,
in this case the Rules-Requires-Root field is redundant and should be removed.
N:
N: Visibility: pedantic
N: Show-Always: no
N: Check: debian/control/field/rules-requires-root
N:
-------------8<-------------8<-----------
And most importantly, your program failed to build from source. Build log:
-------------8<-------------8<-----------
[ 91%] Building CXX object
CMakeFiles/trizbort-qt.dir/src/export/QuestExporter.cpp.o
/usr/bin/x86_64-linux-gnu-g++ -DQT_CORE_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB
-DQT_NO_DEBUG -DQT_WIDGETS_LIB
-I/build/reproducible-path/trizbort-qt-1.0/obj-x86_64-linux-gnu/trizbort-qt_autogen/include
-I/build/reproducible-path/trizbort-qt-1.0/obj-x86_64-linux-gnu/generated
-isystem /usr/include/x86_64-linux-gnu/qt6/QtWidgets -isystem
/usr/include/x86_64-linux-gnu/qt6 -isystem
/usr/include/x86_64-linux-gnu/qt6/QtCore -isystem
/usr/lib/x86_64-linux-gnu/qt6/mkspecs/linux-g++ -isystem
/usr/include/x86_64-linux-gnu/qt6/QtGui -isystem
/usr/include/x86_64-linux-gnu/qt6/QtNetwork -g -O2
-ffile-prefix-map=/build/reproducible-path/trizbort-qt-1.0=.
-fstack-protector-strong -fstack-clash-protection -Wformat
-Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2
-std=gnu++17 -MD -MT CMakeFiles/trizbort-qt.dir/src/export/TadsExporter.cpp.o
-MF CMakeFiles/trizbort-qt.dir/src/export/TadsExporter.cpp.o.d -o
CMakeFiles/trizbort-qt.dir/src/export/TadsExporter.cpp.o -c /build/reproducible
-path/trizbort-qt-1.0/src/export/TadsExporter.cpp
/usr/bin/x86_64-linux-gnu-g++ -DQT_CORE_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB
-DQT_NO_DEBUG -DQT_WIDGETS_LIB
-I/build/reproducible-path/trizbort-qt-1.0/obj-x86_64-linux-gnu/trizbort-qt_autogen/include
-I/build/reproducible-path/trizbort-qt-1.0/obj-x86_64-linux-gnu/generated
-isystem /usr/include/x86_64-linux-gnu/qt6/QtWidgets -isystem
/usr/include/x86_64-linux-gnu/qt6 -isystem
/usr/include/x86_64-linux-gnu/qt6/QtCore -isystem
/usr/lib/x86_64-linux-gnu/qt6/mkspecs/linux-g++ -isystem
/usr/include/x86_64-linux-gnu/qt6/QtGui -isystem
/usr/include/x86_64-linux-gnu/qt6/QtNetwork -g -O2
-ffile-prefix-map=/build/reproducible-path/trizbort-qt-1.0=.
-fstack-protector-strong -fstack-clash-protection -Wformat
-Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2
-std=gnu++17 -MD -MT
CMakeFiles/trizbort-qt.dir/src/export/Inform6Exporter.cpp.o -MF
CMakeFiles/trizbort-qt.dir/src/export/Inform6Exporter.cpp.o.d -o
CMakeFiles/trizbort-qt.dir/src/export/Inform6Exporter.cpp.o -c /build/rep
roducible-path/trizbort-qt-1.0/src/export/Inform6Exporter.cpp
/usr/bin/x86_64-linux-gnu-g++ -DQT_CORE_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB
-DQT_NO_DEBUG -DQT_WIDGETS_LIB
-I/build/reproducible-path/trizbort-qt-1.0/obj-x86_64-linux-gnu/trizbort-qt_autogen/include
-I/build/reproducible-path/trizbort-qt-1.0/obj-x86_64-linux-gnu/generated
-isystem /usr/include/x86_64-linux-gnu/qt6/QtWidgets -isystem
/usr/include/x86_64-linux-gnu/qt6 -isystem
/usr/include/x86_64-linux-gnu/qt6/QtCore -isystem
/usr/lib/x86_64-linux-gnu/qt6/mkspecs/linux-g++ -isystem
/usr/include/x86_64-linux-gnu/qt6/QtGui -isystem
/usr/include/x86_64-linux-gnu/qt6/QtNetwork -g -O2
-ffile-prefix-map=/build/reproducible-path/trizbort-qt-1.0=.
-fstack-protector-strong -fstack-clash-protection -Wformat
-Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2
-std=gnu++17 -MD -MT
CMakeFiles/trizbort-qt.dir/src/export/Inform7Exporter.cpp.o -MF
CMakeFiles/trizbort-qt.dir/src/export/Inform7Exporter.cpp.o.d -o
CMakeFiles/trizbort-qt.dir/src/export/Inform7Exporter.cpp.o -c /build/rep
roducible-path/trizbort-qt-1.0/src/export/Inform7Exporter.cpp
/usr/bin/x86_64-linux-gnu-g++ -DQT_CORE_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB
-DQT_NO_DEBUG -DQT_WIDGETS_LIB
-I/build/reproducible-path/trizbort-qt-1.0/obj-x86_64-linux-gnu/trizbort-qt_autogen/include
-I/build/reproducible-path/trizbort-qt-1.0/obj-x86_64-linux-gnu/generated
-isystem /usr/include/x86_64-linux-gnu/qt6/QtWidgets -isystem
/usr/include/x86_64-linux-gnu/qt6 -isystem
/usr/include/x86_64-linux-gnu/qt6/QtCore -isystem
/usr/lib/x86_64-linux-gnu/qt6/mkspecs/linux-g++ -isystem
/usr/include/x86_64-linux-gnu/qt6/QtGui -isystem
/usr/include/x86_64-linux-gnu/qt6/QtNetwork -g -O2
-ffile-prefix-map=/build/reproducible-path/trizbort-qt-1.0=.
-fstack-protector-strong -fstack-clash-protection -Wformat
-Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2
-std=gnu++17 -MD -MT CMakeFiles/trizbort-qt.dir/src/export/QuestExporter.cpp.o
-MF CMakeFiles/trizbort-qt.dir/src/export/QuestExporter.cpp.o.d -o
CMakeFiles/trizbort-qt.dir/src/export/QuestExporter.cpp.o -c /build/reproduci
ble-path/trizbort-qt-1.0/src/export/QuestExporter.cpp
[ 94%] Building CXX object
CMakeFiles/trizbort-qt.dir/trizbort-qt_autogen/GJ7EMRGEH2/qrc_help.cpp.o
/usr/bin/x86_64-linux-gnu-g++ -DQT_CORE_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB
-DQT_NO_DEBUG -DQT_WIDGETS_LIB
-I/build/reproducible-path/trizbort-qt-1.0/obj-x86_64-linux-gnu/trizbort-qt_autogen/include
-I/build/reproducible-path/trizbort-qt-1.0/obj-x86_64-linux-gnu/generated
-isystem /usr/include/x86_64-linux-gnu/qt6/QtWidgets -isystem
/usr/include/x86_64-linux-gnu/qt6 -isystem
/usr/include/x86_64-linux-gnu/qt6/QtCore -isystem
/usr/lib/x86_64-linux-gnu/qt6/mkspecs/linux-g++ -isystem
/usr/include/x86_64-linux-gnu/qt6/QtGui -isystem
/usr/include/x86_64-linux-gnu/qt6/QtNetwork -g -O2
-ffile-prefix-map=/build/reproducible-path/trizbort-qt-1.0=.
-fstack-protector-strong -fstack-clash-protection -Wformat
-Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2
-std=gnu++17 -MD -MT
CMakeFiles/trizbort-qt.dir/trizbort-qt_autogen/GJ7EMRGEH2/qrc_help.cpp.o -MF
CMakeFiles/trizbort-qt.dir/trizbort-qt_autogen/GJ7EMRGEH2/qrc_help.cpp.o.d -o
CMakeFiles/trizbort-qt.dir/trizbort-qt_autogen/
GJ7EMRGEH2/qrc_help.cpp.o -c
/build/reproducible-path/trizbort-qt-1.0/obj-x86_64-linux-gnu/trizbort-qt_autogen/GJ7EMRGEH2/qrc_help.cpp
/build/reproducible-path/trizbort-qt-1.0/src/TrizbortWriter.cpp: In function
‘QString trizbort::{anonymous}::encodeXmlName(const QString&)’:
/build/reproducible-path/trizbort-qt-1.0/src/TrizbortWriter.cpp:170:45: error:
no matching function for call to ‘QString::arg(char16_t, int, int, QLatin1Char)’
170 | r += QStringLiteral("_x%1_").arg(c.unicode(), 4, 16,
QLatin1Char('0')).toUpper();
| ^
• there are 4 candidates
In file included from /usr/include/x86_64-linux-gnu/qt6/QtCore/QString:1,
from
/build/reproducible-path/trizbort-qt-1.0/src/TrizbortWriter.h:52,
from
/build/reproducible-path/trizbort-qt-1.0/src/TrizbortWriter.cpp:49:
• candidate 1: ‘template<class T, typename
std::enable_if<conjunction_v<std::disjunction<std::is_integral<_Tp>,
std::conjunction<std::is_enum<_Tp>, std::negation<q23::is_scoped_enum<E,
is_enum_v<E> > > > >, std::negation<std::disjunction<std::is_same<typename
std::remove_cv<typename std::remove_reference<_Tp>::type>::type, _Float16>,
std::is_same<typename std::remove_cv<typename
std::remove_reference<_Tp>::type>::type, qfloat16>, std::is_floating_point<_Tp>
> >,
std::negation<std::conjunction<std::negation<QtPrivate::treat_as_integral_arg<typename
std::remove_cv< <template-parameter-1-1> >::type> >, std::is_convertible<T,
QAnyStringView> > > >, bool>::type <anonymous> > QString QString::arg(T, int,
int, QChar) const’
/usr/include/x86_64-linux-gnu/qt6/QtCore/qstring.h:360:27:
360 | [[nodiscard]] QString arg(T a, int fieldWidth = 0, int base =
10,
| ^~~
• template argument deduction/substitution failed:
• error: no type named ‘type’ in ‘struct std::enable_if<false, bool>’
/usr/include/x86_64-linux-gnu/qt6/QtCore/qstring.h:359:53:
359 | template <typename T, if_integral_non_char<T> = true>
| ^~~~
• candidate 2: ‘template<class T, typename
std::enable_if<std::disjunction<std::is_same<typename std::remove_cv<typename
std::remove_reference<_Tp>::type>::type, _Float16>, std::is_same<typename
std::remove_cv<typename std::remove_reference<_Tp>::type>::type, qfloat16>,
std::is_floating_point<_Tp> >::value, bool>::type <anonymous> > QString
QString::arg(T, int, char, int, QChar) const’
/usr/include/x86_64-linux-gnu/qt6/QtCore/qstring.h:375:27:
375 | [[nodiscard]] QString arg(T a, int fieldWidth = 0, char
format = 'g', int precision = -1,
| ^~~
• template argument deduction/substitution failed:
• error: no type named ‘type’ in ‘struct std::enable_if<false, bool>’
/usr/include/x86_64-linux-gnu/qt6/QtCore/qstring.h:374:50:
374 | template <typename T, if_floating_point<T> = true>
| ^~~~
• candidate 3: ‘template<class T, typename
std::enable_if<std::conjunction<std::negation<QtPrivate::treat_as_integral_arg<typename
std::remove_cv< <template-parameter-1-1> >::type> >, std::is_convertible<T,
QAnyStringView> >::value, bool>::type <anonymous> > QString QString::arg(const
T&, int, QChar) const’
/usr/include/x86_64-linux-gnu/qt6/QtCore/qstring.h:380:27:
380 | [[nodiscard]] QString arg(const T &a, int fieldWidth = 0,
QChar fillChar = u' ') const
| ^~~
• candidate expects 3 arguments, 4 provided
• candidate 4: ‘template<class ... Args> typename
std::enable_if<((sizeof... (Args) >= 2) &&
conjunction_v<std::conjunction<std::negation<QtPrivate::treat_as_integral_arg<typename
std::remove_cv<Args>::type> >, std::is_convertible<Args, QAnyStringView>
>...>), QString>::type QString::arg(Args&& ...) const’
/usr/include/x86_64-linux-gnu/qt6/QtCore/qstring.h:400:5:
400 | arg(Args &&...args) const
| ^~~
• template argument deduction/substitution failed:
• /usr/include/x86_64-linux-gnu/qt6/QtCore/qstring.h: In substitution
of ‘template<class ... Args> typename std::enable_if<((sizeof... (Args) >= 2)
&&
conjunction_v<std::conjunction<std::negation<QtPrivate::treat_as_integral_arg<typename
std::remove_cv<Args>::type> >, std::is_convertible<Args, QAnyStringView>
>...>), QString>::type QString::arg(Args&& ...) const [with Args = {char16_t,
int, int, QLatin1Char}]’:
• required from here
/build/reproducible-path/trizbort-qt-1.0/src/TrizbortWriter.cpp:170:45:
170 | r += QStringLiteral("_x%1_").arg(c.unicode(), 4,
16, QLatin1Char('0')).toUpper();
| ^
• error: no type named ‘type’ in ‘struct std::enable_if<false, QString>’
/usr/include/x86_64-linux-gnu/qt6/QtCore/qstring.h:400:5:
400 | arg(Args &&...args) const
| ^~~
make[3]: *** [CMakeFiles/trizbort-qt.dir/build.make:194:
CMakeFiles/trizbort-qt.dir/src/TrizbortWriter.cpp.o] Error 1
make[3]: *** Waiting for unfinished jobs....
make[3]: Leaving directory
'/build/reproducible-path/trizbort-qt-1.0/obj-x86_64-linux-gnu'
make[2]: *** [CMakeFiles/Makefile2:93: CMakeFiles/trizbort-qt.dir/all] Error 2
make[2]: Leaving directory
'/build/reproducible-path/trizbort-qt-1.0/obj-x86_64-linux-gnu'
make[1]: *** [Makefile:139: all] Error 2
make[1]: Leaving directory
'/build/reproducible-path/trizbort-qt-1.0/obj-x86_64-linux-gnu'
dh_auto_build: error: cd obj-x86_64-linux-gnu && make -j96 INSTALL="install
--strip-program=true" VERBOSE=1 returned exit code 2
make: *** [debian/rules:10: binary] Error 25
dpkg-buildpackage: error: debian/rules binary subprocess failed with exit
status 2
--------------------------------------------------------------------------------
Build finished at 2026-09-25T11:20:33Z
-------------8<-------------8<-----------
Please take a look.
Cheers,
--
Luke Yasuda
GPG Fingerprint: 4E09 8D19 00AA 3F72 1899 2614 09B3 316E 13A1 1EFC
signature.asc
Description: OpenPGP digital signature
