On 6/13/07, Philipp Benner <[EMAIL PROTECTED]> wrote:

Package: prolog-el
http://www-lehre.inf.uos.de/~pbenner/debian/prolog-el_1.14-1.dsc

Some comments:

* You might want consider configuring your server (if you are the
sysadmin) to allow people to view the diff.gz in their browser (or
switch to mentors.debian.net instead) This helps drive-by reviewers
such as myself.
* Why do you make changes to the upstream source in both the diff.gz
and also a dpatch?
* What advantages does this package have over the prolog-mode that
comes with Emacs. (Referring to the README.Debian here). Perhaps it
would be good to get those advantages integrated into emacs and this
package removed from debian?
* May want to consider adding a Homepage to the description
* May want to consider using debhelper compat 5

--
bye,
pabs

http://wiki.debian.org/PaulWise


--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to