-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Neutron Soutmun wrote: Sorry, forgot change reply to debian-mentors list.
> Paul Wise wrote: >> On Feb 19, 2008 2:44 AM, Neutron Soutmun <[EMAIL PROTECTED]> wrote: > >>> - - dget >>> http://mentors.debian.net/debian/pool/main/x/xiterm+thai/xiterm+thai_1.07-1.dsc > To whom may download this package before, please re-download for the > update by the comments below: > >> Some comments: > >> Unless you need new features of debhelper compat 6, please leave it at >> the latest compat level available in stable. > > Set it back to debhelper compat 5 (>= 5.0.42) which is in stable, > according to does not need the new features from V6 as your comment. > >> Description suggestion: > >> Description: X terminal program with Thai languague support >> xiterm+thai is an X terminal emulator program with Thai language >> support. It has built-in Thai keyboard input support. You could >> also use the X11 XKB extension to input Thai characters. >> . >> A Thai font is needed to display Thai characters. > > Already fixed. > >> Probably don't need README installed since it is about building, I'm >> guessing README.thai too. Same for COPYRIGHT.HISTORY (copied in >> debian/copyright), doc/README.rxvt.greek - Thai != greek :), and maybe >> the README.xvt too. > > Drop README, COPYRIGHT.HISTORY, doc/README.rxvt.greek, README.xvt. > But README.thai still has some useful infos for Thai people. > >> Perhaps README.thai should be reencoded in UTF-8? > > Convert and install as README.thai-UTF-8 > In debian package install both README.thai and README.thai-UTF-8 which > README.thai can open in xiterm+thai (can not open UTF-8 because it is > TIS-620 environment) and README.thai-UTF-8 can open in the terminals > environment that support UTF-8. > >> What is the reason for having two entries in the menu file? Also, it >> would be good to add a desktop file to support GNOME since by default >> it now doesn't show the Debian menu IIRC. > > Drop unneeded additional menu title="xiterm" as your comment. > Create desktop and icon files for GNOME. > >> The README.Debian needs to be checked and maybe rewritten. > > Rewrite to update infos. > >> txiterm manual page: > >> This isn't really needed "This manual page documents briefly the >> txiterm command". > >> OPTIONS section needs filling out. > > Rewrite too. > >> Very nice changelog entry, good work on the package :) > > Thank you very much, hopefully, I would have a good advices from you > again in the later times :). > >> Shame the package got removed, thanks for working on getting it back in. > Hopefully, it would be back soon. > > Best regards, > - -- - -- Neutron Soutmun http://wiki.debian.org/NeutronSoutmun -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFHw5m81k7Ar9TO/TcRAojeAKDb/BA0ptfgV1j2rm7X7MRYMS43oQCeJFDq xd5WtVH7uY5v6OKpMllsRcU= =0BfC -----END PGP SIGNATURE----- -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

