Vincent Bernat a écrit : > OoO En cette matinée ensoleillée du mardi 08 juillet 2008, vers 09:54, > Vincent Legout <[EMAIL PROTECTED]> disait : > >> * Package name : gimmix >> Version : 0.4.3-1 >> Upstream Author : Priyank M. Gosalia >> * URL : http://gimmix.berlios.de/ >> * License : GPL >> Section : sound >> > Hi Vincent! > Hi, > Not all files are licensed under GPLv2+. For example ./src/eggtrayicon.c > is LGPLv2+. You should list all those exceptions in your > debian/copyright. > I have updated debian/copyright. > debian/compat says 5 while debian/control says debhelper (>= 6). You > should fix this. > Updated to 7. > The fact that Gimmix is a GTK client is more important than the fact it > is written in C. You could tell this is a GTK client in the short > description and drop the fact that it is written in C in the long > description. The long description is a bit short. Maybe you can list > some features of Gimmix. For example, how does it compare with Ario? I have listed all the features in the long description. > The manual page that you wrote is very short. You should use the > template provided by dh-make instead: > /usr/share/debhelper/dh_make/debian/manpage.1.ex > Updated > Your debian/rules seems to use files from automake-1.10. You should > depend on this package instead of just automake, IMO. This will avoid a > FTBFS when automake will switch to a more recent version. > Updated > You should try to get your key signed by some people (preferably DD). If > you live near Paris, I can sign it. > I don't know any DD and I live near Nantes. I don't see how I can get my key signed.
I'm away for two weeks. I won't be able to answer. Thanks for reviewing, Vincent -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
