On Thursday 15 January 2009 07:36:08 Teddy Hogeborn wrote: Hi,
> http://mentors.debian.net/debian/pool/main/m/mandos/mandos_1.0.4-1.dsc Fixing bugs is always nice idea and in fact your new version brings notable improvements compared to the version in sid. However, while checking your new package, I also decided check cppcheck correctness [1] with mandos sources, so it brought my attention to a potential memleak (see patch below) -- memory is not released within that function and there are no chances left to the caller to free it our since NULL is returned. I guess we are better off to fixing that before uploading ? --- plugin-runner.c.orig 2009-01-16 12:59:54.000000000 +0200 +++ plugin-runner.c 2009-01-16 13:00:23.000000000 +0200 @@ -115,6 +115,7 @@ if(name != NULL){ copy_name = strdup(name); if(copy_name == NULL){ + free(new_plugin); return NULL; } } [1] cppcheck version in sid is not that skilled, but you can use the latest svn trunk instead. -- pub 4096R/0E4BD0AB 2003-03-18 <people.fccf.net/danchev/key pgp.mit.edu> -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected]
