أحمد المحمودي wrote: > On Mon, Jan 26, 2009 at 07:41:08PM +0000, Neil Williams wrote: >> On Mon, 26 Jan 2009 13:08:53 -0600 >> Raphael Geissert <[email protected]> wrote: >> >> > > The package appears to be lintian clean. >> > >> > Not really: >> > $ lintian --pedantic -IE --show-overrides sl-modem*dsc >> > W: sl-modem source: debhelper-but-no-misc-depends sl-modem-source >> >> That one is fine, but I'm concerned with your use of --pedantic. > > Sorry that I said that the package is lintian clean, I used the template > that was in mentors.debian.net (seems that there is an old version of > lintian there), and I totally forgot about this warning.
mentors.d.n is not perfect, and you should get used to running lintian on your own :). > I think that > it is fine too, because that package actually builds another package (if > module-assistant is used), or just builds some module files (if DKMS is > used). Have you read the tag's description? it is not as to what the package does. > >> > I: sl-modem source: quilt-patch-missing-description modem_group.diff >> >> Is that the result of --pedantic or just normal lintian? > > Pedantic messages are prefixed with P: > > I fixed & uploaded, except for one patch (04_sregs_init.diff). That was > introduced by previous maintainer. And I don't know what it does. Then that's your homework :) > > Again, please advise me about the use of usermod in the postinst. > Looks fine, but I have one question: why did you disable the version check? Cheers, -- Raphael Geissert - Debian Maintainer www.debian.org - get.debian.net -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected]
