On Fri, Mar 26, 2010 at 6:22 PM, "Adam Cécile (Le_Vert)" <[email protected]> wrote:
> I am looking for a sponsor for the new version 3.3.1-1 > of my package "ophcrack". I'm not doing any additional sponsoring, but here is a review: Please forward the .desktop file and manual pages upstream if you haven't already The upstream README file includes information on downloading and installing ophcrack, which is not relevant for Debian users. I'd suggest asking upstream to split it out into README.install. Upstream is using the ChangeLog file as a NEWS file, you might want to point them at the GNU coding standards document: http://www.gnu.org/prep/standards/standards.html#NEWS-File http://www.gnu.org/prep/standards/standards.html#Change-Logs The upstream code lists the old FSF address in the license grant information, you might want to ask them to fix that. ./src/gui/histogram* are not under the GPL, instead they are under the "Qwt License, Version 1.0". Please document the license and copyright information for these in debian/copyright and ensure this license is compatible with the GPL and OpenSSL licenses. Please run this: sed -i -e 's/in command line/on the command line/' debian/control You may also want to get the description reviewed by the debian-l10n-english folks: http://wiki.debian.org/I18n/SmithReviewProject The package FTBFS on kFreeBSD, it looks like upstream's detection of sysinfo availablility isn't complete, I'd suggest talking to the folks on the debian-bsd list: https://buildd.debian.org/fetch.cgi?&pkg=ophcrack&ver=3.3.0-1&arch=kfreebsd-amd64&stamp=1255940210&file=log https://buildd.debian.org/fetch.cgi?&pkg=ophcrack&ver=3.3.0-1&arch=kfreebsd-i386&stamp=1255940682&file=log You might want to adopt the debhelper 7 dh style rules file: https://penta.debconf.org/dc9_schedule/events/418.en.html http://manpages.debian.net/man/1/dh -- bye, pabs http://wiki.debian.org/PaulWise -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected] Archive: http://lists.debian.org/[email protected]
