On Fri, Mar 26, 2010 at 6:23 PM, "Adam Cécile (Le_Vert)" <[email protected]> wrote:
> I am looking for a sponsor for the new version 0.12.1-1 > of my package "picard". I'm not doing any additional sponsoring at the moment, but here is a review: Please send the manual page upstream if you haven't already. resources/img-src/Copyright.htm indicates that the icons are under a non-free license. Please ask upstream to fix that. If upstream prefers to use a Creative Commons license for them, they need to choose CC >= 3.0 and not any of the NC or ND versions. In the meantime you could remove the icons from the package. Hmm, the AUTHORS.txt file says the icons are from the Tango project, which recentlyish released all their icons into the public domain. If AUTHORS.txt is correct then upstream should remove the Tango icons from the source tarball and the Debian package should depend on tango-icon-theme, which is now in main: http://packages.debian.org/sid/tango-icon-theme picard/browser/filelookup.py looks like it is under the RCSL and not the GPL, despite what it says in the file. Upstream can't just slap on the GPL onto RealNetworks' code, that wouldn't be legal. sed -i -e 's/this three license\./these three licenses./' debian/copyright Check out the PTS page for some other things you might want to do (like merge the Ubuntu patch): http://packages.qa.debian.org/p/picard.html You might want to consider adopting debhelper 7 dh style rules and or DEP5: http://dep.debian.net/deps/dep5/ https://penta.debconf.org/dc9_schedule/events/418.en.html http://manpages.debian.net/man/1/dh -- bye, pabs http://wiki.debian.org/PaulWise -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected] Archive: http://lists.debian.org/[email protected]
