Thanks for the review.  Uploaded 1.3-2 to mentors:
 * Removed the rules boilerplate, and empty doc files. (will check with 
upstream on NEWS v ChangeLog... does look like the ChangeLog should be NEWS 
instead)
 * Fixed a couple of the lintian complaints.

strict-aliasing problems are already reported upstream:  
http://code.google.com/p/google-gflags/issues/detail?id=33

unaddressed lintian compliants:

> I: libgflags0: spelling-error-in-binary ./usr/lib/libgflags.so.0.0.0
> helpfull helpful
> I: libgflags0: spelling-error-in-binary
> ./usr/lib/libgflags_nothreads.so.0.0.0 helpfull helpful

This is actually one of the command-line flags (--helpfull) and not a 
misspelling of helpful.

> X: libgflags0: shlib-calls-exit usr/lib/libgflags.so.0.0.0
> X: libgflags0: shlib-calls-exit usr/lib/libgflags_nothreads.so.0.0.0

These are part of the documented behavior of the library when certain 
command-line flags are sent in (like --help) or when flags have validation 
errors.
(exit is aliased to commandlineflags_exitfunc in the source code)

> I: libgflags0: no-symbols-control-file usr/lib/libgflags_nothreads.so.0.0.0
> I: libgflags0: no-symbols-control-file usr/lib/libgflags.so.0.0.0

Unfortunately the library exports some symbols which are not supposed to be 
public.  Already informed upstream, but the wiki on the symbols control file 
says not to use symbols versioning in this case.

Attachment: signature.asc
Description: Digital signature

Reply via email to