2010/10/24 Enrique Hernández Bello <[email protected]>: > What is the next step? :) > -- > Enrique Hernández Bello >
Hi Enrique, I'm not a DD yet, but I learned a lot from sponsors being extremely picky about my packages. Here are some comments for you to consider: 1) instead of CDBS and explicitly using quilt, would you consider using source format 3.0 (quilt) and debhelper 7 [2]. It should make your debian/rules simpler. It appears that you are using source 3.0 (quilt), but you still have a debian/README.source and explicitly call quilt in your debian/rules. Both of those are probably unnecessary. 2) in debian/rules you have this comment: # dh_fixperms and override_dh_fixperms didn't work. The reason it doesn't work is that you are not using debhelper 7 type build system, but CDBS. See [2] for how to make debhelper 7 type rules. 3) Consider reformatting your debian/copyright to DEP-5 [3] (this is nit-picking, but good form for a new package). 4) Consider formatting your patch descriptions to DEP-3 [4] (this too is nit-picking, but good form for a new package). 5) Since this is the first debian release of your package, I would remove all your debian/changelog entries except for: fritzing (0.4.3b-1) unstable; urgency=low * Initial release (Closes: #601230) This is your first release, and version 0.4.3b-1 makes sense to me as the first debian packaging released. 6) I like the control.in and debian/rules magic to have different dependencies between debian and ubuntu. I haven't seen that before, and it prevents a diff between the two. 7) "$ lintian --pedantic -I" is clean. Of the above comments, I think (5) is probably the most important. I suggest doing 1-4 as an exercise in "good form" [1] http://wiki.debian.org/Projects/DebSrc3.0 [2] http://www.debian.org/doc/maint-guide/ch-dreq.en.html#s-defaultrules [3] http://dep.debian.net/deps/dep5/ [4] http://dep.debian.net/deps/dep3/ -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected] Archive: http://lists.debian.org/[email protected]
