On Wed, Mar 16, 2011 at 02:51:26PM +0100, Ansgar Burchardt wrote: > Michael Tautschnig <[email protected]> writes: > > Looks pretty good, and I really like the fact that multiple people seem to > > be > > working on it, makes package maintenance a lot more future-proof :-) Built > > and > > uploaded! > > > > Just one thing, though, that I don't really like, which you might want to > > reconsider for the next release: > > > > rm -rf ${PIDDIR} > > > > Couldn't this be avoided by doing some rm -f ${PIDDIR}* ; rmdir ${PIDDIR} > > (probably you can't do an rm -f without *, which would have been even > > nicer). rm > > -rf just feels so unsafe... > > Your suggested change looks unsafer to me. It will do evil things when > $PIDDIR is empty while the original version does nothing in that case.
I wonder if Michael meant rm -f "${PIDDIR}"/* with the slash :) (IMHO the quotes
would also be a good idea)
G'luck,
Peter
--
Peter Pentchev [email protected] [email protected] [email protected]
PGP key: http://people.FreeBSD.org/~roam/roam.key.asc
Key fingerprint FDBA FD79 C26F 3C51 C95E DF9E ED18 B68D 1619 4553
What would this sentence be like if it weren't self-referential?
signature.asc
Description: Digital signature
