* Alessandro Ghedini <[email protected]>, 2011-06-02, 15:57:
http://mentors.debian.net/debian/pool/main/c/cityhash/cityhash_1.0.2-1.dsc

I saw this in city.h:

| typedef uint8_t uint8;
| typedef uint32_t uint32;
| typedef uint64_t uint64;
| typedef std::pair<uint64, uint64> uint128;
|
| inline uint64 Uint128Low64(const uint128& x) { return x.first; }
| inline uint64 Uint128High64(const uint128& x) { return x.second; }

It is not acceptable to define such a generic names in a public header. Please educate your upstream not to do that.

--
Jakub Wilk


--
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]
Archive: http://lists.debian.org/[email protected]

Reply via email to