William, On Mon, 2011-06-27 at 08:22 -0500, William Vera wrote: > On Mon, Jun 27, 2011 at 4:07 AM, Kilian Krause <[email protected]> wrote: > > Hi William, > > > > > > 1. README.source still talks about dpatch despite changelog reads > > package converted. > > Updated for quilt
Good.
> >
> > 2. libx11-6 is now always pulled in via Depends. You can safely edit
> > README.Debian to reflect this or rather remove it entirely.
>
> It's in Recommends because it's used by 'webspy' not properly by 'dnisff'
> IMHO it's fine how is in README.Debian
Your resulting deb is:
$ dpkg -I dsniff_2.4b1+debian-21_amd64.deb|grep libx11
Depends: libc6 (>= 2.7), libdb5.1, libice6 (>= 1:1.0.0), libnet1 (>=
1.1.2.1), libnids1.21, libpcap0.8 (>= 0.9.8), libsm6, libssl1.0.0 (>=
1.0.0), libx11-6, libxmu6, openssl
(requires libx11-6 installed).
$
obviously setting Depends, not Recommends. Thus your README.Debian is
kinda bogusly telling the user to install something she already has
installed.
> >
> > 3. in debian/rules why is
> > override_dh_auto_configure:
> > dh_auto_configure -- --host=$(DEB_HOST_GNU_TYPE) --build=
> > $(DEB_BUILD_GNU_TYPE) --prefix=/usr --mandir=\$${prefix}/share/man
> > --infodir=\$${prefix}/share/info
> >
> > needed and different from the debhelper7 automagic configuration?
>
> Not really, droped
Good.
> >
> > Apart from this fine for upload into Debian IMHO.
> >
>
> Thanks for you review, the packages is updated:
> http://mentors.debian.net/debian/pool/main/d/dsniff/dsniff_2.4b1+debian-21.dsc
built, signed, uploaded.
Thanks!
--
Cheers,
Kilian
signature.asc
Description: This is a digitally signed message part
