uploaded. thanks for your contribution to debian.
:) On Tue, Nov 1, 2011 at 10:48, Shell Xu <[email protected]> wrote: > > 2011/11/1 Jakub Wilk <[email protected]> >> >> * Shell Xu <[email protected]>, 2011-10-31, 23:55: >>> >>> http://mentors.debian.net/package/python-snappy >>> >>> There still a lintian INFO about desc, but I copied it from google code. >>> Do I need to fix it? >> >> The sentence lintian is complaining about >> (using-first-person-in-description) is: "Snappy is widely used inside >> Google, in everything from BigTable and MapReduce to our internal RPC >> systems." This certainly doesn't make sense in a description of a _Debian_ >> package. >> >>> Alternatively, one can download the package with dget using this command: >>> >>> dget -x >>> http://mentors.debian.net/debian/pool/main/p/python-snappy/python-snappy_0.3.2-1.dsc >> >> I'm not interested in sponsoring this package, but here's my very quick >> review: >> >> You probably want to build-depend on "python-all-dev", not "python-dev, >> python2.6-dev, python2.7-dev". >> >> Please consider building also a package for Python 3.X, as upstream seems >> to support it, too. >> >> I think the long description is a bit too verbose. The part that refers to >> the underlying library is even longer that description of libsnappy1 itself. >> >> In debian/copyright, you don't need to repeat copyright information in the >> License field. >> >> debian/docs is empty, so... just delete it. >> >> Remove libsnappy1 from Depends. This dependency will be automatically >> generated by dpkg-shlibdeps. >> >> The binary package doesn't depend on python. It's because you forgot to >> add ${python:Depends} to Depends. >> >> -- >> Jakub Wilk >> >> >> -- >> To UNSUBSCRIBE, email to [email protected] >> with a subject of "unsubscribe". Trouble? Contact >> [email protected] >> Archive: http://lists.debian.org/[email protected] >> > > I fixed all other problems, except python3 packaging. Do I have to make > two different source packages to make python-snappy and python3-snappy? > dh_python2 not work with more than one binary package in one control file. > > -- > 无能者无所求，饱食而遨游，泛若不系之舟 > blog: http://shell909090.com/blog/ > twitter: http://twitter.com/shell909090 > -- Best Regards LI Daobing -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected] Archive: http://lists.debian.org/caehct7nd-npydqlacao1m4bopdqpt_yeffkbvyck_vhbjvr...@mail.gmail.com
