On Tue, Jun 05, 2012 at 05:20:29AM +0000, Bart Martens wrote: > Hi Bas, >
Hi Bas, I'm now reviewing your upload of 2012-06-05 07:30. > I suggest to do the following changes: > - Remove machine/m_gnu.c from debian/patches/ptop_hurd, OK. > - Add "cp -f machine/m_linux.c machine/m_gnu.c" to debian/rules, I don't find any "cp" in debian/rules. Did you use a different approach ? > - Add debian/clean containing "machine/m_gnu.c", I don't see any file that matches debian/*clean. Did you use a different approach ? > - Add similar changes for the other arch(s) with the same problem, > - Rename debian/patches/ptop_hurd to debian/patches/archs, The patch debian/patches/archs contains this line: + kfrebsd-gnu*) MODULE=linux;; Is that a typing mistake ? > - Update "Architecture:" in debian/control. It's set to "Architecture: any" now. Are all architecture related problems solved ? > > I'm not sure about removing hppa and powerpcspe from ptop's archs list because > I don't know the issue with debhelper on these archs. Is it really a > permanent > problem ? Maybe ptop can have "Architecture: any". > This page > http://buildd.debian-ports.org/status/package.php?p=debhelper&suite=sid > states "No entry in hppa database, check Packages-arch-specific" but this page > https://buildd.debian-ports.org/quinn-diff/sid/Packages-arch-specific > seems to fail at this time. You seem to have decided to include both hppa and powerpcspe. Is the problem with debhelper on hppa and powerpcspe solved or not permanent ? I see that you have updated debian/copyright, but it is not ready yet. Please look at the file LICENSE and compare that to debian/copyright. They currently don't match. Also, please scan the upstream source code for copyright notices and licenses. For example, the file pg_trace.h contains "Copyright (c) 2006, PostgreSQL Global Development Group" and that is not yet mentioned in debian/copyright, and it is not clear whether pg_trace.h has the same license as the one in the file LICENSE. Regards, Bart Martens -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected] Archive: http://lists.debian.org/[email protected]
