* Bart Martens <ba...@debian.org> [120819 11:46]: > Hi Etienne, > > I had a look at your package at mentors uploaded there on 2012-08-17 21:41.
Hello, Thanks for this review. It seems that I was beaten by licensecheck on the remaining cases. > http://www.debian.org/doc/debian-policy/ch-docs.html#s-copyrightfile > "should name the original authors" > > The file AUTHORS contains this : > > | Qball <qb...@sarine.nl> > | LibertyZero <m...@libertyzero.com> > | > | Artwork: > | Jakub Szypulka > > So this should be mentioned in debian/copyright. On the other hand > there is bug 678607, so maybe this is not so important anymore. I added this information as a comment. > The file doc/Mallard/C/legal.xml contains this : > | <p>This work is licensed under a > | <link href="http://creativecommons.org/licenses/by-sa/3.0/";>Creative > Commons > | Attribution-Share Alike 3.0 Unported License</link>.</p> > | <p>As a special exception, the copyright holders give you permission to > copy, > | modify, and distribute the example code contained in this document under > the > | terms of your choosing, without restriction.</p> Fixed. I added the full text of the license as it is not part of common-licenses. > The file glade/aboutdialog.ui seems GPL-2, not GPL-2+ because I > don't see the usual phrase about the "+". Everything else contains the "or later version" phrase, so I assume this is an error. I'll forward this bug upstream. > Also, the copyright year 2003 is not yet in debian/copyright. > > The file gnome-doc-utils.make is Copyright (C) 2004-2005 Shaun McCance > <sha...@gnome.org>. > > Some files in po/*.po are Copyright (c) 2011 Rosetta Contributors and > Canonical > Ltd 2011. Fixed^3. The license for po/Makefile.in.in has a spelling error ("GNU Public License"), should I add a lintian override? I reuploaded a new version of the package, still at the same URL : http://mentors.debian.net/debian/pool/main/g/gmpc/gmpc_11.8.16-4.dsc Thanks again ! Have a nice day. -- Etienne Millon -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20120819103711.GA3780@klow
