Thank you for all your comments. I will come back later with a new upstream release, especially for the font rendering which requires big changes. That was probably something to be done anyway, since I guess it would improve the font rendering quality which I was not too happy about. For the rest I will make the necessary changes.
bye, Raphael 2012/11/23 Paul Wise <[email protected]>: > You might be interested in joining the Debian games team: > > http://wiki.debian.org/Games/Team > > Here is a review of your package: > > You are missing a watch file: > > http://wiki.debian.org/debian/watch > > You don't include any FreeDesktop menu or Debian menu files, so > non-technical users will probably not be able to start your game on > Debian. > > I would suggest to update debian/compat to 9 and change the debhelper > build-dep to 9 > > Your Makefile does not support DESTDIR. > > Your Makefile includes this very inappropriate line: > > CC=g++ > > I would suggest dropping the whole release/debug thing, this will > allow you to use the more standard CXXFLAGS instead of > CXXFLAGS_RELEASE/CXXFLAGS_DEBUG/CXXFLAGS_COMMON. Alternatively you > could just switch to a standard build system like autotools or cmake. > > I would strongly suggest that the text be rendered at runtime or at > the very least the PNG files created from the DejaVu font should > rendered at build time from ttf-dejavu. Rendering the text at runtime > will allow you to add translations, making the game accessible to more > users. I would recommend quesoglc for this. I would recommend these > files be rendered at runtime or build time: > > data/images/chars/* > data/images/license.png > data/images/title.png > data/images/first.png > > I would suggest that these files be created from mouse.png at build > time using imagemagick or similar: icon.ico icon32.bmp > > The eagle.png image looks like it was cut out of some off-the-shelf > clipart. Are you the copyright holder for that? Where did the image > come from? Is there an SVG/WMF that it was rendered from (best render > at build time)? > > You are embedding a copy of SOIL. Please remove that from the upstream > tarball and build-depend on libsoil-dev instead. That would also get > rid of one gcc warning, one lintian warning and two cppcheck warnings. > > Your debian/changelog includes UNRELEASED in the suite, shouldn't that > be "unstable"? > > All of the files in src/ have "All rights reserved." in them but no > license statement: > > http://tieguy.org/blog/2012/03/17/on-the-importance-of-per-file-license-information/ > > Your configuration file loading should use getpwuid() or similar if > getenv('HOME') fails. > > src/Functions.* are not valid UTF-8. > > You might want to use the new format for debian/copyright: > > http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ > > Since you are upstream for a game, please read these documents: > > http://wiki.debian.org/UpstreamGuide > http://www.freedesktop.org/wiki/Games/Upstream > > Automatic checks from here: > > http://wiki.debian.org/HowToPackageForDebian#Check_points_for_any_package > > gcc: > > gcc -O2 -s -Wall -o obj/stb_image_aug.o -c ../../src/stb_image_aug.c > ../../src/stb_image_aug.c: In function 'parse_png_file': > ../../src/stb_image_aug.c:2341:28: warning: variable 'invalid_chunk' > set but not used [-Wunused-but-set-variable] > > lintian: > > P: miceamaze source: source-contains-prebuilt-windows-binary SOIL/testSOIL.exe > I: miceamaze source: debian-watch-file-is-missing > P: miceamaze: no-upstream-changelog > > cppcheck: > > [SOIL/src/original/stb_image-1.16.c:2924]: (error) Memory leak: out > [SOIL/src/stb_image_aug.c:2651]: (error) Memory leak: out > > isutf8: > > src/Functions.h: line 63, char 1, byte offset 11: invalid UTF-8 code > src/Functions.cpp: line 84, char 1, byte offset 20: invalid UTF-8 code > > > -- > bye, > pabs > > http://wiki.debian.org/PaulWise > http://bonedaddy.net/pabs3/ -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected] Archive: http://lists.debian.org/CA+_0haKPXFcbaTa76pWt_s+oZBSNEex2MPeL44HiBxGh=rf...@mail.gmail.com
