(I don't intend to sponsor this package.)
* Christoph Mathys <[email protected]>, 2012-11-17, 21:39:
http://mentors.debian.net/debian/pool/main/m/mercurial-keyring/mercurial-keyring_0.5.3-1.dsc
lintian emits:
X: mercurial-keyring source: python-depends-but-no-python-helper
mercurial-keyring
P: mercurial-keyring source: unversioned-copyright-format-uri
http://dep.debian.net/deps/dep5
I: mercurial-keyring source: debian-watch-file-is-missing
I: mercurial-keyring: capitalization-error-in-description Gnome GNOME
Additionally, lintian4python emits:
e: mercurial-keyring: python-module-not-byte-compiled
usr/lib/python2.7/dist-packages/mercurial_keyring.py
e: mercurial-keyring: missing-requires.txt-dependency keyring => python-keyring
e: mercurial-keyring: pyflakes-undefined-name
usr/lib/python2.7/dist-packages/mercurial_keyring.py:86: url
It's unclear to me how the upstream part is licensed. PKG-INFO says both
"License: GPL" and "Classifier: License :: OSI Approved :: BSD License".
Could you please clarify this with upstream? Also please ask them to
include full license text in the tarball.
The "Sample debian/rules that uses..." comment doesn't make sense.
Please remove it.
Why priority extra?
What is python-gnomekeyring dependency for? I don't see any references
to this module in the source.
Shouldn't the package depend on... mercurial? :)
The package is fully architecture-independent, so Architecture should be
"all", not "any".
I'd use "debhelper (>= 8)" instead of "debhelper (>= 8.0.0)".
Current standards version is 3.9.4.
Build-dependency on python-all is missing
The package FTBFS when built twice in a row:
| dpkg-source -b mercurial-keyring-0.5.3
| dpkg-source: info: using source format `3.0 (quilt)'
| dpkg-source: info: building mercurial-keyring using existing
./mercurial-keyring_0.5.3.orig.tar.gz
| dpkg-source: info: local changes detected, the modified files are:
| mercurial-keyring-0.5.3/mercurial_keyring.egg-info/SOURCES.txt
| dpkg-source: error: aborting due to unexpected upstream changes, see
/tmp/mercurial-keyring_0.5.3-1.diff.FUtlxd
debian/docs is empty... Wouldn't it make sense to install README.txt
into the binary package?
--
Jakub Wilk
--
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]
Archive: http://lists.debian.org/[email protected]
