-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256
On 23/02/13 09:09, Markus Wanner wrote: > Anton, > > that's very useful feedback, thanks a lot. I figured I run lintian > from wheezy, that's why I didn't notice most of this. > > On 02/23/2013 08:02 AM, Anton Gladky wrote: >> as I understood from #583862, you have found a sponsor for the >> package, right? > > Looks like it, yeah. > >> 1) Use DEP-3 for patches (at least Description, Author, >> Last-Update). 2) Remove the fix-makefile.patch, which is not >> listed in debian/patch/series 3) Changelog-entry #2 is not >> necessary IMHO. 4) Compat 7 should be better changed to the newer >> 9 as well as BD in control. It will allow also to inject >> hardened buildflags. 5) Standards-Version is already 3.9.4 6) As >> I understood from #583862, there is already a VCS on >> collab-maint, add corresponding fields into control-file. 7) Use >> in debian/rules dh_auto_configure -- --prefix=........ instead of >> "configure". It should be more "nicely" 8) dh 9 sets the >> "correct" buildflags in many cases. Do you really need to set >> them explicitly? 9) Add --parallel option to dh for faster >> building. 10) The upload should be targeted to experimental >> branch due to a freeze-period. > > I'll take care of these Monday - at the latest. > Just a further thought on the Debian-specific patches: you could revert all the Debian patches simply by unpacking 1.4.2.orig into the master branch and making a commit. Then you would be able to successfully import 1.4.[3-8] without any merge conflicts. Finally, you would need to look at whether any of the Debian-specific changes to upstream code need to be re-applied - but some of those changes may be unnecessary as the things they fix may already be fixed by upstream in 1.4.8 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBCAAGBQJRKICvAAoJEOm1uwJp1aqDPlQQAKjPh8OYs7DGhgwXWJrXKDFk KPnj1HtEWeYWESY5ifDs1J0LoWyMPWkDFGgwIV55XqS0b4X05N+FbdH0IVBIu/Hp 9L67jrXDlIapqF96CQ/R5atkKr7Ccf9TNIfsxNOanXXz71NSD+Zii+r8CElyNyq3 qaqPYlxkOGW4fafA9PZv6vbpSSqwxWL9yPcVbQQ6+B8nAsjgQlX3GLgrkxIvJ6sV 3i6y8Kp225KB9jvFBfkXzlyaJlcDgjGpZnmUtf7OlmBpEtk10BSM99lOxtQ2K+Bx zdi92dGEw8ayb3Zx+1dSEnU47KlEyYqUoMVSI+YQazScE74gJtbmL6cy/p5u0leL A2aeLh2hbxPpr8clUgXoEVn9jMQ77M1zfkA3gUaCvvPEKxBiM+XapaEJtTSF4hN0 mmpn1L0MZxJpmEaf4zdXYRBOGzcoqADPcckKeCs/5GcHuezOOF2XlIz71n9gYM+p O+s54CPiNbQ3px0foAPiHT8govAH3mVqjqxHVQxTflk3+zQ8vcEpLBOfMZKiFfSd J3BPqMhRQRyYMbI0jz+bYN2w/SCoCDxtgjKMhAmSU5+MHBJ9e+25D/SeB48ldRwH Hjoj8e+wxLoOkx/bp4r8zVWesFumgBNxTBjBCiaLHRwu5c3G0NV/X/pAVpzbbiZD QefkDwvC9dwnO9SorCTU =kh6y -----END PGP SIGNATURE----- -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/512880af.4070...@pocock.com.au