Hello,
I had a quick look to your package. Note that I'm not a DD so I can't
upload your package.
- for a NMU, the package version should be -15.1, not -16.1
- I think that your changes a bit invasive for a NMU. Most notably,
changing the packaging system is not OK even if using quilt
directly is outdated. If you decide to adopt this package, it's
good though.
- the package does not build in a clean chroot. FWIW use a i386
system and the log tail is :
Preparing completed. You may now run "make" (or "gmake").
dh_auto_build
make[1]: Entering directory `/tmp/buildd/html2text-1.3.2a'
g++ -c -D_FORTIFY_SOURCE=2 -DVERSION=1.3.2a -DAUTO_PTR_BROKEN -O2 -g
-mcmodel=large html2text.C
html2text.C:1:0: error: code model 'large' not supported in the 32 bit
mode
make[1]: *** [html2text.o] Error 1
- You bumped S-V, were there any changes ? (ie, did you review the
checkilist?)
- the "this patch header follows DEP3" comment is probably superfluous
- in debian/rules, the commented lines are useless
Thanks for taking care of html2text !
--
Etienne Millon
--
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]
Archive: http://lists.debian.org/20130511100216.GA3951@klow
