Adam Borowski <[email protected]> writes: > Let's add some WTF to FTPmasters' day! :)
This package is a perfect fit for a personal archive, but if anyone wants to upload it: you're in for a race for the fastest REJECT ever. We have enough WTFs a day already, thankyouverymuch. But I'm in a good mood today, so here's some criticism: * debian/rules without arguments does not behave sanely: make: *** No targets. Stop. It should at least do something, but "no targets" is unexpected. It says the same when tcc is not installed too, instead of failing violently for build-deps not being present. * It unconditionally rewrites debian/control This is REJECT reason alone. You simply don't do that. * debian/rules with an invalid target name still works: debian/rules binary == debian/rules yranib It should produce an error. This kind of unexpected behaviour is confusing, and not something we want in the archive. We already have CDBS for that[1], thank you. * There is no error checking: Trying to build the package in a chroot that doesn't have enough space: it will result in an empty, invalid package. The return value of mkdir(), system() and all that needs to be checked, or you're not complying with Policy 4.6. * d/rules can be exploited by an overly long version string * The binary created by d/rules is invalid: algernon@hadhodrond:/tmp/b$ dget -x -u http://mentors.debian.net/debian/pool/main/g/goodbye/goodbye_0.3-1.dsc dget: retrieving http://mentors.debian.net/debian/pool/main/g/goodbye/goodbye_0.3-1.dsc % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 1440 100 1440 0 0 342k 0 --:--:-- --:--:-- --:--:-- 703k dget: retrieving http://mentors.debian.net/debian/pool/main/g/goodbye/goodbye_0.3.orig.tar.xz % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 1824 100 1824 0 0 471k 0 --:--:-- --:--:-- --:--:-- 1781k dget: retrieving http://mentors.debian.net/debian/pool/main/g/goodbye/goodbye_0.3-1.debian.tar.gz % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 3133 100 3133 0 0 133k 0 --:--:-- --:--:-- --:--:-- 145k dpkg-source: info: extracting goodbye in goodbye-0.3 dpkg-source: info: unpacking goodbye_0.3.orig.tar.xz dpkg-source: info: unpacking goodbye_0.3-1.debian.tar.gz algernon@hadhodrond:/tmp/b$ cd goodbye-0.3/ algernon@hadhodrond:/tmp/b/goodbye-0.3$ debian/rules binary ar: creating ../goodbye_0.3-1_all.deb doing: [binary]\n algernon@hadhodrond:/tmp/b/goodbye-0.3$ dpkg-deb -c ../goodbye_0.3-1_all.deb dpkg-deb: error: archive has no newlines in header And indeed, debian-binary contains "2.0\n", and no newline. * Debugging d/rules is unnecessarily hard I can' easily attach gdb to figure out what's wrong. stracing it is painful too. * root:root owner is not enforced in the control.tar.gz: algernon@hadhodrond:/tmp/b/goodbye-0.3$ tar tzvf control.tar.gz -rw-r--r-- algernon/algernon 723 2013-07-15 17:35 control This is reject worthy too. -- |8] [1]: I'm just picking on CDBS, because I can. Feel free to substitute anything else, dh short form, dbs, dpatch, dh-exec, you name it. -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected] Archive: http://lists.debian.org/[email protected]
