> [Needs work] Johann Felix Soden at 2014-01-04 20:40:10.849740 > > Hi Sebastien, > > I had a look at your package. The most things are well-done, but I found the > following things which you should fix: > > - put the header file and the .so link in a separate -dev package. The idea > of this is, that multiple versions of the library package with different > SONAME can be installed at the same time. See > http://www.debian.org/doc/debian-policy/ch-sharedlibs.html > Do not forget to remove the lintian override. > > - complete debian/copyright: > Include all copyright holders and the full license text (see e.g. the > header of decode.c) > > - enable hardening: > DEB_BUILD_HARDENING=1 works only with hardening-wrapper (which is not in > the build-deps). > Use instead in debian/rules > DPKG_EXPORT_BUILDFLAGS = 1 > include /usr/share/dpkg/buildflags.mk > and add $(LDFLAGS) to the final linking for the "-Wl,-z,relro" flag > see https://wiki.debian.org/Hardening > > - remove line 3-7 of debian/rules - this comment is not necessary > > - remove trailing whitespaces in debian/copyright > > I did not yet look at everything, so there might be more to fix. > > Best regards, > Johann Felix Soden
Hi Johann, Thank you very much ! According your comments, I've just fixed and uploaded a new version on mentors. If you have any time to re-review this package, I really appreciate. https://mentors.debian.net/package/libx86emu I still have a lintian warning about « hardening-no-relro », but I don't known how to fix it :-/ Thanks ! Best regards, Sebastien -- Sebastien Badia Xmpp/mail: <[email protected]> -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected] Archive: http://lists.debian.org/[email protected]
