On Mon, 27 Jan 2014, Paul Wise escribió:

> On Mon, 2014-01-27 at 01:44 +0100, Sebastien Badia wrote:
> 
> > Therefore we do anything with this package? RoQA anyway?
> 
> Thanks for the explanation, it sounds like this package should remain in
> Debian instead of being removed, good luck with finding a sponsor.

Hi Pabs,

I will do it.

Sebastien, some comments. Your package seems to be fine, good job, but some 
changes are welcome.

In the debian/changelog file, you included that this new version fixes all 
lintian warnings and errors.
Please, include the lintian problems that your changes solve 
(quilt-patch-missing-description, out-of-date-standards-version, 
spelling-error-in-manpage,...). These changes are related with these comments:

- The description in the debian/control file was updated, you should include it 
in the changelog file.
- The debian/copyright file was updated, you should include it in the changelog 
file.
- The files debian/patches/02_typo_fix.patch and 
debian/patches/06_asused_pod.patch were modified. You should include these 
changes in the changelog file (DEP-3, whitespaces, typos,...). The Subject line 
for patch 02 should change too, because now are three typos, no only one. You 
can change the file name if you want.

I will upload the package after these changes.

Thanks a lot,
Best regards,
kix
-- 
 .''`.  Rodolfo García Peñas (kix) <k...@debian.org>
: :'  : Proud Debian Developer
`. `'`  4096R / 3F48 0B8C C385 AD41 9E28  006A 7B1F 5490 72B7 4923
 `-     Debian - when you have better things to do than fixing systems


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20140128213843.ga5...@kix.es

Reply via email to