Hi Eriberto, Thanks for reviewing my package. I reuploaded it to mentors.d.n. I also uploaded to a private git repository, because I don't have access to collab-maint. See my notes below on your points.
On Tue, Sep 02, 2014 at 10:25:06AM -0300, Eriberto Mota wrote:
> Hi Joseph.
>
> Please:
>
> 1. d/changelog:
> - Change from 'Add Joseph Bisch as maintainer (Closes: #735288)'
> to 'New maintainer (Closes: #735288)'.
Done
> 2. Remove all garbage: d/changelog.{BACKUP.21866, BASE.21866,
> LOCAL.21866, REMOTE.21866}. These files are trash or references to
> Ubuntu d/changelog.
Done
> 3. d/control:
> - Why the package recommends zenity | kdebase-bin? I am afraid
> because kdebase-bin is a monster (a detail: I use KDE). I need you
> invetigate this dependency.
> - Do you have access to collab-maint? If not, you must create an
> external VCS and import all data.
> - The long description appears a mix between long description and
> README. Please, move this content to README.Debian (you can create a
> new section below the Jari Aalto and put a footer with your name):
>
> About pckages in Recommends header: to use GUI progress bar, install
> package "zenity". To read manuals, install package "xdg-utils". If
> you need to cache any *.iso files with the -k option, install package
> "sudo" or sudo GUI "gksu".
> .
> NOTE: This package suggests installing package libwine. Some, but not
> all package downloads depend on restarting the wineserver which is
> included in libwine.
> .
> NOTE: In case you have compiled wine from sources and installed it
> out of dpkg(1)'s control, winetricks' depends wouldn't know about it. In
> that case create a "dummy wine" package to satisfy depends by using
> tools in "equivs" package before installing winetricks. An example:
> .
> git clone [email protected]:jaalto/project--debian-wine-dummy.git
> cd project--debian-wine-dummy
> make
> dpkg -i wine*.deb
> apt-get install winetricks
>
>
I moved all the stuff to README.Debian. I don't have access to collab-maint,
so I changed the Vcs fields to a private repo. I think the package
recommends zenity | kdebase-bin because of Kdialog which can be used as an
alternative to zenity. What do you think I should do about it?
>
> d/copyright: you need update the upstream name list and years in
> 'Files: *'. you can use 'grep -sri copyright * | grep -v debian'.
Done
> d/rules: I suggest move the winetricks.svg install to d/install. it
> will avoid two points of installation.
Done
> d/watch: doesn't show the last version.
What do you suggest I do? The watch file is setup for the actual releases,
but the previous maintainer has been packaging the version directly from
svn. I guess I can figure out a way to get the watch file working with
Google Code source browser.
> d/clean: currently, this file hasn't a function.
Removed.
Thanks,
Joseph
signature.asc
Description: Digital signature
