2014-09-03 11:24 GMT-03:00 Ruben Undheim <[email protected]>: > Hi Eriberto,
Hi!!! >> Sorry, but I need you review each file. As an example, Everaldo Canuto >> hasn't copyright over src/gui/osm-utils.h, src/gui/osm-gps-map-ais.c >> and src/gui/osm-gpsmap-ais.h. There is a other case. I didn't see the >> name Matti Aarnio in copyright. Use 'grep -sriA30 copyright *' to >> search. Thanks! >> > > I made yet another attempt and uploaded. I'm not sure if I understand fully. > Do I also have to split up the * target if not every copyright holder > listed holds the copyright for every single other file? No! You did right now. Very, very good. > I just did the same change to the /usr/local/share/... path as for > /usr/share/. I agree that > it is unnecessary, but I don't see that it could cause any problems > since the program tries > to open the files with READ permission. > I have updated the patch so that it only changes /usr/share/.. Following the FHS, a package can't install or modify anything in /usr/local. So, you must keep the original ways to /usr/local. I also suggest don't put anything in /usr/local as upstream. The /usr/local is reserved to local admin/users and local programs only. >> Ok. There are cases that you need a "text" in menu. You can keep it . >> But I think that it is uncommon. Maybe you can use a script to start >> gnuais and gnuaisgui via menu. What you think about it? >> > > I think it's a good idea. But since I'm the main upstream contributor, > I believe I will attempt to make this a bit more user-friendly in the > next version (that gnuais is automatically started in the background > by gnuaisgui if not already running). Ok. IMHO, if the GUI starts the gnuais, it is another reason to don't create an entry in menu. I think that we need prevent an unnecessary menu pollution. > > > Thanks a lot, > > Ruben Your package is ok for me now. Uploaded. Thanks a lot for your work. Cheers, Eriberto -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected] Archive: https://lists.debian.org/CAP+dXJe_Pcuy5d1nr3wpJX4Vt5vUhkix5NpotyXW0=8xczr...@mail.gmail.com
