Control: tags -1 pending Control: owner -1 ! Control: block 763888 by -1 # indicating that I will sponsor this package
Hi Alexandre, On Sat, 2014-10-04 at 01:54 +0200, Alexandre Detiste wrote: > Hi, > > > cruft is orphaned (#763888), so you dont do a NMU, as technically there > > is no maintainer. Instead, do a QA-upload. See > > https://www.debian.org/doc/manuals/developers-reference/pkgs.html#nmu-qa-upload > > Ok, it wasn't orphaned at the time I did the RFS. > > Here is a new package: > > http://mentors.debian.net/package/cruft Just downloaded. We will start a review right away after some entry words :) I saw from [1] that this is your first package, therefore I'd like you to introduce you to a few important documents linked from http://mentors.debian.net/intro-maintainers §3. You should sometime read them (you don't need to be able to recite them from memory, but you should familiarize with them to know where to look up) This will help down the road, especially if you intend to regulary contribute or even become DM/DD at some time) Additionally you should browse https://wiki.debian.org/DebianMentorsFaq As [1] is emtpy, I will be a little more verbose below, apologizes if I tell you something you already know. BTW, don't be scared, it is normal that a review list is huge in the first iteration, Ok, so let me briefly go over your email and then start finally the review.. (I peeked already, so there will be already some remarks) > > Of course, it would be even better if would consider adopting the > > package... > > I would like to. Great! But you need to indicate this on the package, not in this mail :) So, to indicate that you will adopt, you need to do: -> Change the Orphaning Bug to an Intent-To-Adopt-Title (ITA:) one and set yourself as owner (see https://www.debian.org/devel/wnpp/#howto-o and https://www.debian.org/Bugs/server-control; bts(1) is also a useful tool for manipulating bug status) -> Close the Bug in your d/changelog. (some entry like "New maintainer (Closes: #763888) -- (d/ is short for the debian/ directory in your package) -> Set yourself as Maintainer in d/control (and remove the likely inactive Uplpoader; he can be added in case of again) > > As a QA upload allows you to fix litteraly everything, it would be great > > if you could reduce the bug count a little bit :) > > I already solved 3 bugs, they will be automaticaly closed by the amended > changelog. Thats the way to go. If you like, you can also tag those bugs "pending" > Most others are not bugs, but feature requests; > my own biggest complaint is that it is soooo slow, even on a new PC. > > After one week of thinkering, I had rewritten the cruft engine from scratch > and it is already 30x to 100x faster. > https://github.com/a-detiste/cruft-ng > https://github.com/a-detiste/cruft-ng/wiki/Benchmark > > It tries to have an output identical to cruft. > > It doesn't support any command line argument at the moment > but it is already usefull to myself for testing the cruft ruleset, and fix it > faster. > > This let me also find new bugs in cruft: it doesn't grok multiarch, > and can't realise that libc6:amd64 & libc6 are the same thing. > > I would like at first to package this as "cruft-ng (with Depends: cruft)" > so that users can compare output. (This getting off topic, I suggest you file an ITP (against pseudo package wnpp) that you are ITP cruft-ng; You can also ping me to sponsor this when ready. Just one remark: Depends should be only used when appropriate -- refer to Policy §7.2 -- so only if cruft-ng requires cruft to operate) > It's my first C++ program after 10 years of SQL & SAS, the code is ugly. > > This in not even real C++, just C + strings + vectors + lot of calls to C > library; > I would better rewrite it in plain C. Of course this won't be completed for > Jessie. Don't rush it... There will be a jessie+1 :) > > (So, yes, I'm willing to sponsor you if you bring the package into > > shape :-) > Ok, that would be great. > > I've filled up the needed form for Debian Maintainer > https://nm.debian.org/public/person/detiste Slow,slow :) NM is to become a DD. But before that is possible you need to be involved already, have some work done already. Usually the way is first to contribute, then after a while, apply for a DebianMaintainer and then again after a while apply to become DD. https://wiki.debian.org/DebianMaintainer https://www.debian.org/devel/join/ > > > (Antonjy: You are listed as uploader... I assume that this is obsolete > > as your last upload for this package was 1998. please confirm) > Lintian complaints about that too. This error will go away after you adopted the package (as described above) > Thanks ! > Ok, to the review. (Some words ahead: I usually just unordered lists of things I see, but I will not offer solutions how to fix it. This is to encourage research and learning why this is so. --> If you're stuck, ask.) -> d/changelog: There was an upload Oct3 -> you need to rebase your d/changelog to include the changes from 0.9.17 (skip the unreleased nmu) As said above, adapt to correct adopting "Mentored upload... " --> delete that line, as it has no information on changes. -> d/control Standard Version 3.9.6 is out ;-) Regarding VCS-*, they need some update as you need to keep them actual Maybe those options would be - Clone the repository e.g in github so you have access (fastest result) - Ask Marcin if you can get commit access - (maybe long term, because won't be instant) move repository to alioth - temporarily remove VCS-* (not recommended) I would go for the first now, and ask Marcin for access. VCS-* can always be updated in a subsequent upload. (Note: Seems that Marcin did not push the tag for 0.9.17 -- please make sure to tag this release. Tool recommendation: git-buildpackage -> d/copyright Comment: should go, not needed. You need to add your name to the "*" section (as you are also becoming upstream, I guess. Its a native package afterall :)) -> d/cruft.lintian-overrides Please remove the lines when no longer needed, not just only comment it. -> d/docs is empty Remove file if not needed. -> d/dirs *might* not be needed, as debhelper will create the dirs for you usually. So check if can be cleaned up Ok, the list is not really long. Good job! Please update the package, replay to this mail and say what you changed, put it to mentors, and give me a ping. -- Tobi [1] https://qa.debian.org/developer.php?login=alexandre.detiste% 40gmail.com -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected] Archive: https://lists.debian.org/[email protected]
