d/clean is your friend :) I pushed a fix to the repository: Adding debian/clean
tobi@edoras:~/workspace/deb/mentors/_done/abcmidi/abcmidi$ cat debian/clean Makefile config.h config.log config.status -- tobi Am Samstag, den 25.10.2014, 18:45 +0200 schrieb Ross Gammon: > On 10/25/2014 09:29 AM, Ross Gammon wrote: > > <snip> > > > On 10/25/2014 01:18 AM, Tobias Frost wrote: > >> Many thanks James! Valid points > >> > >> Ross, please also consider those comments. Especially please fix > >> the build system. I missed that during my review, sorry, but I > >> will file a bug for that. > >> > >> Am Montag, den 20.10.2014, 21:59 +0100 schrieb James Cowgill: > > <snip> > > >>> The clean target doesn't work because you disabled it. This is > >>> a violation of debian policy (4.9) "clean (required): This > >>> must undo any effects that the build and binary targets may > >>> have had" > >>> > > Okay, this is now driving me nuts! I have restored dh_auto_clean and > patched the upstream makefile so the clean target does not fail when > run before the build. > > But still the package does not clean properly. I assumed this was > because I was forced to override dh_auto_install and manually run > make. So I added dh_auto_clean to the end of the > override_dh_auto_install. This manages to run the upstream clean > target okay, but still leaves autoreconf cruft behind. > > I can't work out how to pass the "--with autoreconf" option to > dh_auto_clean (which I assume would done automagically if I didn't > have the override). > > The d/rules snippet is here: > %: > dh $@ --with autoreconf > > override_dh_auto_install: > #Upstream prefix is usr/local so manually call make > $(MAKE) DESTDIR=$$(pwd)/debian/abcmidi prefix=/usr install > #Remove duplicate license information > rm $(CURDIR)/debian/abcmidi/usr/share/doc/abcmidi/gpl.txt > #Remove duplicate changelog file > rm $(CURDIR)/debian/abcmidi/usr/share/doc/abcmidi/CHANGES > #Remove superfluous VERSION file > rm $(CURDIR)/debian/abcmidi/usr/share/doc/abcmidi/VERSION > #Remove duplicate AUTHORS file > rm $(CURDIR)/debian/abcmidi/usr/share/doc/abcmidi/AUTHORS > dh_auto_clean > > And you can find the git repo here: > http://anonscm.debian.org/cgit/collab-maint/abcmidi.git > > Cheers, > > Ross > > -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected] Archive: https://lists.debian.org/[email protected]
