-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Hi,
sorry for the long wait! I did a deep review, and I guess I found the last "showstoppers" 1) Upstream revision seems to be "2.1-3" and you seem to have introduced a first dfsg revision so it becomes 2.1-3+dfsg and then the debian revision, so 2.1-3+dfsg-1 what do you think about? this should make easier for people to understand where upstream stops and where Debian starts BTW if you have to strip other non-dfsg files you might just change dfsg to dfsg1 and live happy, and if you need a new Debian upload, you can change -1 to -2, that way people will understand the revision correctly. (note: this might imply a change in debian/NEWS too) 2) control: the pre-depends might be dropped after jessie I guess, but you can leave them because they are mentioned on the wiki (somebody wrote about updating the wiki, but I won't ask to remove them for now, because they might be useful for backports and lintian doesn't complain) 3) I would appreciate a get-orig-source target called by uscan, that way you can have a repack for free, otherwise another person looking at the source might introduce non dfsg files in the packaging. you can look at files-excluded https://wiki.debian.org/UscanEnhancements or write your own get-orig-source.sh script e.g. (boinc) version=3 opts=dversionmangle=s/\+dfsg$// \ https://github.com/BOINC/boinc/tags .*/client_release/\d\.\d/(\d.*)\.tar\.gz \ debian /bin/sh debian/get-orig-source.sh 4) manpages should belong to dh_installman instead of dh_install. e.g. debian/package.manpages (or dh_installman(1)) 5) export DEB_CFLAGS_MAINT_APPEND = -Wall -g export DEB_LDFLAGS_MAINT_APPEND = -Wl,-z,defs ifneq (,$(findstring noopt,$(DEB_BUILD_OPTIONS))) DEB_CFLAGS_MAINT_APPEND += -O0 else DEB_CFLAGS_MAINT_APPEND += -O2 endif are you sure this is needed? AFAIK with compat level 9 this is addressed automatically, unless upstream overrides the flags. cheers, G. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWB6sDAAoJEPNPCXROn13Znt4P/iUTZ+HhLzW+F9zgk7UCElW4 hzzO+liIunglzGnP9a21g5bwlrqiys01sbFAEDB5PVfNMtUnceR6580gsr2bE95P 3TZR0UzcADqnQQAEKIGFoRCm6N7Kudmk3zVUZTrTKYZgCzNSk6b6gm2mtUJzfiB7 uoll+4hgsB0ysZJszHc+9FYTZT01+YJvUIhfm5MK+o7MKccgl2mEszVX2AiWQE03 BQMvCcSXbq8w9aN5MOcBBuQTAjUwvmMdBvQXytpranHEu+sEjarWrMotl+um08lu C4397J0AXnXj7NdRrM4e0IoXCllQjq5QGnt3AuXKFumQI491futU3RTDERDes68h bHd+HKrFQyKYOW4y4ywxi0Sd93GNBYHR5WDU9CD2/8tYv7qGu6CadhA/cd195gJT uW8EDssz0Rdd1QqRqDSGgiO9OosurHkVzwkxRRQ+Xae4148wzb3z12byGscPeoLI xklTIPRr0bcwIcXUsbsn9XvPxvl3Vqwj3bdyY9fhs56OBCgzIatBpDQq5dQvuXq0 bVXc+TN7jKlSY7BqwsfNsU64HwilUKGObH0nLeOfmojfqUTN+XioY4ZwBv6AlY9q O9CS6SOkFiyjIyOsUTrBjAEnlIDJxj3gDgrnyra6r4g1KhrkSaujoeSuNWNbL3VX pbZrfcNHUSK+9X+Zt/O9 =bIIH -----END PGP SIGNATURE-----
