On Mon, Nov 2, 2015 at 11:54 PM, Daniel Stender <[email protected]> wrote:
> -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA512 > > Package: sponsorship-requests > Severity: wishlist > Control: block 796309 by -1 > X-Debbugs-CC: [email protected] > > Hi, > > I'm looking for a sponsor for my package of Gox, a cross compilation > builder for Go: > https://github.com/mitchellh/gox I’ve noticed the resulting package ships /usr/share/gocode/src/… — is that intentional? Does it make sense to ship the library code, i.e. will other programs use gox as a library? On first glance, it looks like a binary only, but you might be more familiar with gox. > > > I've created an initial package within a new pkg-go repo: > https://anonscm.debian.org/cgit/pkg-go/packages/gox.git (new, maybe not > yet populated) > > Buildlog: > http://www.danielstender.com/buildlogs/gox_0.3.0-1_amd64-20151102-2329.build > > Mentors upload: > http://mentors.debian.net/package/gox > http://mentors.debian.net/debian/pool/main/g/gox/gox_0.3.0-1.dsc Just FYI, for packages that I sponsor, you don’t need to upload to mentors. I’ll build directly from git. > > The package builds and works fine, but for some reason the tests don't run > through. > The only failing test I can see is: === RUN TestGoVersion --- FAIL: TestGoVersion (0.25s) go_test.go:24: bad: "go1.5.1" This is the code in question: func TestGoVersion(t *testing.T) { v, err := GoVersion() if err != nil { t.Fatalf("err: %s", err) } acceptable := []string{"devel", "go1.0", "go1.1", "go1.2"} found := false for _, expected := range acceptable { if strings.HasPrefix(v, expected) { found = true break } } if !found { t.Fatalf("bad: %#v", v) } } So, the package expects to be compiled with go1.0, go1.1, go1.2, but anything newer is definitely unacceptable…?! Given we have the Go 1 stability guarantee (see https://golang.org/doc/go1compat), that test strikes me as not useful. I recommend suggesting upstream to delete the test, and then packaging a new snapshot. We definitely want the other tests to run at package-build time. > > Thank you very much for considering, > Daniel Stender > > - -- > 4096R/DF5182C8 > 46CB 1CA8 9EA3 B743 7676 1DB9 15E0 9AF4 DF51 82C8 > LPI certified Linux admin (LPI000329859 64mz6f7kt4) > http://www.danielstender.com/blog/ > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v2 > > iQIcBAEBCgAGBQJWN+mTAAoJEBXgmvTfUYLIfQAP/iA805ir2/rUoytC9pkAi8pj > /r1LUxMhqF4kuHVLtGJCxmNviUMkG10IUqVBXYOtVLQmbgYghQGCuSl1LoAePjWr > lE5mrsTvPcEtPw0rLE1hPv9JUlJPSHaoKCAzOQOlRpXuATFurHmLl7vQKrjQajMf > 9fHszTtZei+8aIhWoQQtq8je4CyTMk3Ju6l8rsoiDRcjn1K0kUrDmrdnI31z8D3v > 0XfDYXnPVhalg9TKBsWYAl5ojLoqK9rHT4t+BZ3HFRxY3Za7RAFJguPmkwPOtdQr > H9JKzagE/gr5MD+pkyG2w5Swp51V733ujWMkKsZNuawqO3xUmoLUttQ3/HjsuLr6 > hkDF2R9YWGv0A7gmHLkAvflDe1P+zAH/tYQ+HRTQXTNueFDDnJT1HTGYC/CVEC7Z > voI3u+IIyY03cYx9SJmZqb1SDI6pH1bUB1LpnpmAehWHMrrIoqQFiiWuY6VIpk1s > nPrNlqq3j94dgFB6VNzInJ184WDApfrAiFpgysOk5T+m6+4J0PbKfV4ZnuTJ7zsU > 8sgwf/HI2x4IHKvl81MUOzeZi6WZWmG7i0D7w6hvmFsZ9mhALlDjHQf7mzsiPr/A > gKmEkbTscVf9xI0Wg+O+7l6MxfssF0hhl9uBtK8wvp82l8e0gDgUJCXBWtnLkbDZ > /V+J09mJFd+UDS+W8mfY > =0ZTO > -----END PGP SIGNATURE----- > > _______________________________________________ > Pkg-go-maintainers mailing list > [email protected] > http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers > -- Best regards, Michael
