On Sun, Dec 13, 2015 at 03:49:08AM +0100, Jerome BENOIT wrote: > On 13/12/15 03:19, Mattia Rizzolo wrote: > > * why don't you try to use the git repository in a sane way? just > > importing .dsc you build somehow else is not really a good use of it, > > It is why I do NOT import dsc material, but I use the same kind of message. > And I group the git-commit to avoid numerous ones.
well, 1 huge incomprehensible commit for sure doesn't help either. afetr all that's the debian packaging VCS, if you don't do little commits what's the whole point of it? I can create a nearly identical repository with gbp import-dscs --debsnap 4ti2 which downloads all the historical releases and push them into a git repository.... => nice for historical reasons, but nearly useless... > > * I guess > > - debian/{patches,adhoc}/*: > > - test walk 344, revive; > > In the previous package version, the test named walk failed over a sample > input data file > with generic name 344: it was frozen and I sent a report to the upstream > maintainer team, > along other minor reports. > This version of 4ti2 mainly fixed the reported issues, see the (upstream) > NEWS file for > more details. So I unfrozen this test and I performed some minor changes in > the debian > material to reflect the fixes brought by the upstream team. Those changes are > minor > in the sense that they mainly concern maintenance, but not end users. > I like something like: - debian/patches: - name-of-that-patch: remove to re-enable the test walk with 344. - patch1, patch2, patch3: drop, applied upstream - patch4: add to do blablabla - refresh. > I try to be concise. I guess that what you mean is that I should git-commit > more often. It's important to be concise (something that honestly I fail to do pretty often), but it also important to always have enough information, and this is even more important given that the changes done are impossible to obtain otherwise (you don't have a useful VCS) if you don't want to read the huge debdiff. It's not uncommon that in a far future somebody will be interested in changes done now. -- regards, Mattia Rizzolo GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`. more about me: http://mapreri.org : :' : Launchpad user: https://launchpad.net/~mapreri `. `'` Debian QA page: https://qa.debian.org/developer.php?login=mattia `-
signature.asc
Description: PGP signature