On Sun, Dec 20, 2015 at 11:48:07PM +0100, Peter Spiess-Knafl wrote: > > trailing whitespaces: + debian/control:15 + debian/rules:3 > > Applied forgotten wrap-and-sort
wrap-and-sort doesn't touch debian/rules.
Also, in this process you added new trailing whitespaces (`git diff`
(and friends, like `git log -p` and `git show`) shows them in red
here...)
debian/patches/fix-changelog-typos.patch:1
debian/patches/fix-changelog-typos.patch:2
debian/patches/fix-fsf-address.patch:2
> > there is really no need to do that useless
> > override_dh_auto_install, just empty that target in d/rules, and
> > write 'rfcdiff' in debian/rfcdiff.install
>
> The makefile seems to be for internal development use only. Also
> Fedora is working around that faulty makefile.
[...]
> Therefore I would like to keep the current version until upstream
> comes up with a fixed version, with proper test and install targets
> (including DESTDIR and PREFIX variables).
yeah, I don't mean you to patch the makefile, please re-read my quote
above.
that work in override_dh_auto_install + .install file is duplicated for
nothing.
I'm proposing the attached patch, what do you think?
> I re-uploaded a modified verion to mentors.
> Thanks for taking the time.
btw, I'll happily work through git, given that you have a packaging
repository, and you're using it sanely I'd use it, rather than going
with tarballs, is way easier for me.
Just poke when you do changes to review/upload.
--
regards,
Mattia Rizzolo
GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`.
more about me: http://mapreri.org : :' :
Launchpad user: https://launchpad.net/~mapreri `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia `-
diff --git a/debian/rfcdiff.install b/debian/rfcdiff.install
index e772481..ca62b14 100644
--- a/debian/rfcdiff.install
+++ b/debian/rfcdiff.install
@@ -1 +1 @@
-usr/bin
+rfcdiff
diff --git a/debian/rules b/debian/rules
index cd07313..04703b7 100755
--- a/debian/rules
+++ b/debian/rules
@@ -17,8 +17,7 @@ override_dh_auto_test:
# nothing
override_dh_auto_install:
- mkdir -p $(CURDIR)$(DESTDIR)/debian/tmp/usr/bin
- cp rfcdiff $(CURDIR)$(DESTDIR)/debian/tmp/usr/bin
+ # nothing
override_dh_auto_clean:
rm -f debian/rfcdiff.1
signature.asc
Description: PGP signature
