On 20/03/16 06:24, Mattia Rizzolo wrote: > control: tag -1 moreinfo > control: owner -1 ! > > On Fri, Mar 18, 2016 at 08:49:21PM +0100, Gordon Ball wrote: >> I am looking for a sponsor for my package "r-cran-pbdzmq" > > hi there (3rd time ;))
And thanks again. > >> http://mentors.debian.net/debian/pool/main/r/r-cran-pbdzmq/r-cran-pbdzmq_0.2.1+dfsg-2.dsc > > this looks nicer from a license POV, at least! > > * debian/changelog: > + what happened to version -1 ? These packages (and quite a few others) are already in a PPA [1] (which I hope to make more debian uploads), and hence I can't recycle old versions. > * debian/control: > + (Build-)Depends are not sorted, please sort them (wrap-and-sort(1) > and cme(1) may help here) > + outdated Standards-Version > + very very short extended descript, please make it longer Done. > * DESCRIPTIONS: > + the Copyright field points to non-existant files, that may actually > be interesting to read, where are they? (I see one is excluded in > d/copyright, why?) The upstream distribution contains a complete source copy of libzmq, and built objects for windows. The package builds against system libzmq3-dev. The excluded copyright file covers the bundled library, which is hence unneeded. The remaining files in src/ are the bindings to libzmq which should be covered by the package license (GPL-3). > * inst/doc/pbdZMQ-guide.pdf > + PDFs are tricky [1], and should be stripped out of the tarball and > built at build time, it surely looks feasible, may you do it? Excluded from 0.2.1+dfsg2. It does not appear common in R packages to build package vignettes (Rnw/Rmd) into their compiled forms (PDF/html), so I haven't added rules to re-compile it - this should probably be done at the debian R policy level rather than individually. > * debian/tests: > + I wonder if an autodep8 thing for R would make sense, after having > seen 3 quasi-identical tests for 3 different R packages > It probably would, but I don't know how to go about it. I added these tests based on similar ones used for nodejs packages. > > [1] https://ftp-master.debian.org/REJECT-FAQ.html (grep for PDF) > The changes are uploaded to d/mentors [2] as r-cran-pbdzmq 0.2.1+dfsg2-1 ("dfsg2" since the PPA already built against the existing DFSG tarball). [1]: https://launchpad.net/~chronitis/+archive/ubuntu/jupyter/ [2]: http://mentors.debian.net/package/r-cran-pbdzmq
