Hi Aurelien! Thanks for the great contribution!
- I modified debian/rules to pass -DWITH_ARCH=riscv64. It's not clear if > that part should go upstream, it seems given we do not have CPU > specific optimizations to add in cmake/scripts/linux/ArchSetup.cmake > so it's not fully necessary. Please tell me if I am wrong, I'll submit > that upstream The Debian packaging for Debian and upstream are totally different, so you can send only cmake/scripts/linux/ArchSetup.cmake part there if needed. >- Patch 0024-add-riscv-compile-defines.patch is coming from upstream and > will be in Kodi 20. It conflicts with 0006-fix-s390x-build and > 0009-fix-alpha-build patches whichh touch the same files. As 0024 is > already upstream and will appear at some point in the Debian package, > I have moved the 0006 and 0009 patches after it and "rebased" them as > 0025 and 0026. I must check if 19.x has that patch. As for 20.x nightlies, let me explain my intention below >- Patch 0027-link-with-pthread.patch changes the way cmake handles > Thread support to correctly link with -pthread instead of -lpthread. > That way GCC automatically pulls in -latomic if needed. I have noticed > that debian/rules already forces LDFLAGS to contain -latomic, however > it appears too early in the linker command to be early (it needs to be > after the objects needing this library). Does it apply to other architectures? I recall I had to fix "-latomic" stuff in KissFFT… >If you are fine with this patch, could you please consider applying it >in the future uploads? If you aren't, do not hesitate to comment, ask >for more details or ask for changes to the patch Do you expect to have this in 19.x or 20.x? Right now, I would like to have 19.x propagated across unstable, testing, stable and oldstable-backports. However, I don't know if SRM accept changes of every upcoming bugfix release, so I try to keep debdiffs for 19.x as small as possible. Of course there might be a solution by diverting +deb11u1 but let's get 19.2 into stable first. As for 20.x, I will be building unofficial repo for stable-backports and unstable/testing, and there we can experiment as we like. -- Vasyl Gello ================================================== Certified SolidWorks Expert Mob.:+380 (98) 465 66 77 E-Mail: [email protected] Skype: vasek.gello ================================================== 호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다
