Your message dated Sun, 03 Apr 2022 16:19:14 +0000
with message-id <[email protected]>
and subject line Bug#964148: fixed in harvid 0.9.0-1
has caused the Debian Bug report #964148,
regarding harvid FTCBFS: hard codes the build architecture pkg-config
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
964148: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=964148
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: harvid
Version: 0.8.3-2
Tags: patch
User: [email protected]
Usertags: ftcbfs
harvid fails to cross build from source, because its Makefiles hard code
the build architecture pkg-config. Just making it substitutable is not
enough, since it requires a working pkg-config for the install target,
but debhelper only passes it during dh_auto_build. dpkg's buildtools.mk
can help here. Please consider applying the attached patch.
Helmut
diff --minimal -Nru harvid-0.8.3/debian/changelog harvid-0.8.3/debian/changelog
--- harvid-0.8.3/debian/changelog 2020-06-30 12:08:34.000000000 +0200
+++ harvid-0.8.3/debian/changelog 2020-07-01 23:21:52.000000000 +0200
@@ -1,3 +1,12 @@
+harvid (0.8.3-2.1) UNRELEASED; urgency=medium
+
+ * Non-maintainer upload.
+ * Fix FTCBFS: (Closes: #-1)
+ + Make pkg-config substitutable.
+ + Pass PKG_CONFIG to all targets.
+
+ -- Helmut Grohne <[email protected]> Wed, 01 Jul 2020 23:21:52 +0200
+
harvid (0.8.3-2) unstable; urgency=medium
* Team upload.
diff --minimal -Nru harvid-0.8.3/debian/patches/cross.patch
harvid-0.8.3/debian/patches/cross.patch
--- harvid-0.8.3/debian/patches/cross.patch 1970-01-01 01:00:00.000000000
+0100
+++ harvid-0.8.3/debian/patches/cross.patch 2020-07-01 23:21:44.000000000
+0200
@@ -0,0 +1,57 @@
+--- harvid-0.8.3.orig/common.mak
++++ harvid-0.8.3/common.mak
+@@ -13,6 +13,7 @@
+ hdocdir ?= $(docdir)/harvid
+
+ ECHO=$(shell which echo) -e
++PKG_CONFIG ?= pkg-config
+
+ ARCHFLAGS=
+ ARCHINCLUDES=
+--- harvid-0.8.3.orig/libharvid/Makefile
++++ harvid-0.8.3/libharvid/Makefile
+@@ -2,7 +2,7 @@
+
+ FLAGS=
+ FLAGS+=$(ARCHINCLUDES) $(ARCHFLAGS)
+-FLAGS+=`pkg-config --cflags libavcodec libavformat libavutil libswscale`
++FLAGS+=`$(PKG_CONFIG) --cflags libavcodec libavformat libavutil libswscale`
+ LIBHARVID_OBJECTS = \
+ decoder_ctrl.o \
+ ffdecoder.o \
+@@ -52,7 +52,7 @@
+ $(LIBHARVID_OBJECTS) \
+ $(CFLAGS) $(FLAGS) \
+ .libharvid_dll.c dlog_null.c \
+- $(LDFLAGS) `pkg-config --libs libavcodec libavformat libavutil
libswscale` $(ARCHLIBES)
++ $(LDFLAGS) `$(PKG_CONFIG) --libs libavcodec libavformat libavutil
libswscale` $(ARCHLIBES)
+ $(STRIP) libharvid.$(LIBEXT)
+
+ libharvid.dylib: $(LIBHARVID_OBJECTS) $(LIBHARVID_H) .libharvid.sym
+--- harvid-0.8.3.orig/src/Makefile
++++ harvid-0.8.3/src/Makefile
+@@ -8,20 +8,20 @@
+
+ CONFIGTEMP=conf.out
+
+-ifeq ($(shell PKG_CONFIG_PATH=$(PKG_CONFIG_PATH) pkg-config --exists
libavcodec libavformat libavutil libswscale || echo no), no)
++ifeq ($(shell PKG_CONFIG_PATH=$(PKG_CONFIG_PATH) $(PKG_CONFIG) --exists
libavcodec libavformat libavutil libswscale || echo no), no)
+ $(error "http://ffmpeg.org is required - install libavcodec-dev,
libswscale-dev, etc")
+ endif
+
+-ifeq ($(shell PKG_CONFIG_PATH=$(PKG_CONFIG_PATH) pkg-config --exists libpng
|| echo no), no)
++ifeq ($(shell PKG_CONFIG_PATH=$(PKG_CONFIG_PATH) $(PKG_CONFIG) --exists
libpng || echo no), no)
+ $(error "libpng is required - install libpng-dev")
+ endif
+
+ FLAGS=-I../libharvid/
+ FLAGS+=$(ARCHINCLUDES) $(ARCHFLAGS)
+-FLAGS+=`pkg-config --cflags libavcodec libavformat libavutil libpng
libswscale`
++FLAGS+=`$(PKG_CONFIG) --cflags libavcodec libavformat libavutil libpng
libswscale`
+
+ LOADLIBES=$(ARCHLIBES)
+-LOADLIBES+=`pkg-config --libs libavcodec libavformat libavutil libpng
libswscale`
++LOADLIBES+=`$(PKG_CONFIG) --libs libavcodec libavformat libavutil libpng
libswscale`
+ LOADLIBES+=-ljpeg
+ LOADLIBES+=-lz -lm
+
diff --minimal -Nru harvid-0.8.3/debian/patches/series
harvid-0.8.3/debian/patches/series
--- harvid-0.8.3/debian/patches/series 2020-06-30 12:08:34.000000000 +0200
+++ harvid-0.8.3/debian/patches/series 2020-07-01 23:19:16.000000000 +0200
@@ -1,3 +1,4 @@
drop_jpeg_test.patch
0004-fix-parallel-building.patch
spelling.patch
+cross.patch
diff --minimal -Nru harvid-0.8.3/debian/rules harvid-0.8.3/debian/rules
--- harvid-0.8.3/debian/rules 2020-06-30 12:08:34.000000000 +0200
+++ harvid-0.8.3/debian/rules 2020-07-01 23:21:52.000000000 +0200
@@ -1,6 +1,8 @@
#!/usr/bin/make -f
include /usr/share/dpkg/pkg-info.mk
+DPKG_EXPORT_BUILDTOOLS=1
+-include /usr/share/dpkg/buildtools.mk
export DEB_BUILD_MAINT_OPTIONS = hardening=+all
--- End Message ---
--- Begin Message ---
Source: harvid
Source-Version: 0.9.0-1
Done: Sebastian Ramacher <[email protected]>
We believe that the bug you reported is fixed in the latest version of
harvid, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Sebastian Ramacher <[email protected]> (supplier of updated harvid package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Sun, 03 Apr 2022 18:14:03 +0200
Source: harvid
Architecture: source
Version: 0.9.0-1
Distribution: unstable
Urgency: medium
Maintainer: Debian Multimedia Maintainers <[email protected]>
Changed-By: Sebastian Ramacher <[email protected]>
Closes: 964148 1004826
Changes:
harvid (0.9.0-1) unstable; urgency=medium
.
* Team upload
.
[ IOhannes m zmölnig (Debian/GNU) ]
* Add salsa-ci configuration
* Fix FTCBFS: Make pkg-config substitutable.
Thanks to Helmut Grohne <[email protected]> (Closes: #964148)
* Fix FTCBFS: Pass PKG_CONFIG to all targets.
Thanks to Helmut Grohne <[email protected]> (Closes: #964148)
.
[ Sebastian Ramacher ]
* New upstream version 0.9.0
- Fix build with ffmpeg 5.0 (Closes: #1004826)
* debian/patches: Refresh patches
Checksums-Sha1:
bce819d684511695f670c170cd993885b0ca0220 2056 harvid_0.9.0-1.dsc
b422bbc5210103bab346b92e05683d06b3933a35 116909 harvid_0.9.0.orig.tar.gz
670cbef35c7fe5873122db8538e40a3eac1fd69c 5368 harvid_0.9.0-1.debian.tar.xz
Checksums-Sha256:
fae233f80e92869be73ecef62c051106b7c96d7568cfa0f336f378bf99649b4d 2056
harvid_0.9.0-1.dsc
8a4b97271fe88f95bdd42cc48089674b5b36f5c16741be6da06c825d818fc8f3 116909
harvid_0.9.0.orig.tar.gz
6a47121ed85998e91de1d8c1833090bdab93605f0cd35eac294b2df91d81c799 5368
harvid_0.9.0-1.debian.tar.xz
Files:
74eb11eafd9521c0ef72d3eaedc8ff02 2056 video optional harvid_0.9.0-1.dsc
1a3287becfc7ca5ea8a9b00b449cc65d 116909 video optional harvid_0.9.0.orig.tar.gz
8f71877426c8cef4069670bad0e4b0ca 5368 video optional
harvid_0.9.0-1.debian.tar.xz
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEE94y6B4F7sUmhHTOQafL8UW6nGZMFAmJJyBsACgkQafL8UW6n
GZPWbw//a+1lK1/yu1lK2K/9aGQ/0VrxJ1yDdx78wlGoPR5mrai9kRNPbDK63HSa
wsn3dMDlJlPVD9dRbUNu3Lcf+uNGUwTxo0y5pe0kn764FUL1X6X5PbosHi3xBbo1
OHPKE12FLvT14yC3mhwH4754HR3kio5OfObrnqckloIJiQUWE7FhIodBT4rVvEfu
AhtLcdnFFJA0U96eG9XawjNf1jzUJ/4vA4pYWZRRVA5ycwqispZ82TWGBCTqlT+q
lFuMQasQ5HHgTHNxRSgRhPL91FwaIQVUkAQZGFdact2CltrF3+iZPquCOTzN3ThA
+UCFZboZn4JFXCwpiMMbLyaJDxZKv3qs/1JVCH20rgla+IIN0PJvhK2xgyoUebt0
5tV/Wy4QK4Kb35O2V59IvWSfkWh5eGmUWLfFUxTJ+mHT3WtdfxMJsl77V1UqhY5x
hFE08lh+GugfmYCC/qqR2K0SQLSxi9ITYwVqHLVfZ/CIafYMYnQ4sprahZ6f22my
2C7Hdz/B1jVR+fy922s78Cg/bK5WsRWjJSKqBlnY6W4SgbU2kWNk407ifnKc3IUT
zxOC0Jw8svS4o7dEwPtGBYy/WkAsf1GCXP9Fol+hVPfX3D6HFF/spMAebN8H01WI
QmfrHWV0hysYPXJQIW1Q2U+pdN9waWrHNfvOH0mEAqj/dVh6Wk8=
=d7eq
-----END PGP SIGNATURE-----
--- End Message ---
