Your message dated Wed, 13 Dec 2023 21:07:58 +0000
with message-id <[email protected]>
and subject line Bug#1058582: fixed in roc-toolkit 0.3.0+dfsg-5
has caused the Debian Bug report #1058582,
regarding The build tests are not enabled in the Debian package
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1058582: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1058582
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: roc-toolkit
Version: 0.3.0+dfsg-4
Tags: patch
User: [email protected]
Usertags: origin-ubuntu noble ubuntu-patch
I'm was looking at libroc for Ubuntu since it's a new depends for
pipewire and noticed that upstream provide tests which aren't enable in
the package build. The attached patch make the tests run as part of the
package build, I've testing it in a ppa and seems to work as expected
https://launchpadlibrarian.net/702261581/buildlog_ubuntu-noble-amd64.roc-toolkit_0.3.0+dfsg-4ubuntu1~build1_BUILDING.txt.gz
```
debian/rules override_dh_auto_test
...
python3 scripts/scons_helpers/timeout-run.py 300
bin/x86_64-pc-linux-gnu/roc-test-core
..................................................
..................................................
..................
OK (118 tests, 118 ran, 86418 checks, 0 ignored, 0 filtered out, 11 ms)
```
It would be nice if the tests were also enabled in Debian
Cheers,
Sébastien Bacher
diff -Nru roc-toolkit-0.3.0+dfsg/debian/changelog roc-toolkit-0.3.0+dfsg/debian/changelog
--- roc-toolkit-0.3.0+dfsg/debian/changelog 2023-12-02 09:58:05.000000000 +0100
+++ roc-toolkit-0.3.0+dfsg/debian/changelog 2023-12-12 21:03:29.000000000 +0100
@@ -1,3 +1,9 @@
+roc-toolkit (0.3.0+dfsg-5) UNRELEASED; urgency=medium
+
+ * Enable build tests
+
+ -- Sebastien Bacher <[email protected]> Tue, 12 Dec 2023 21:03:29 +0100
+
roc-toolkit (0.3.0+dfsg-4) unstable; urgency=medium
* Restrict Build-Deps on libunwind-dev only on supported architectures
diff -Nru roc-toolkit-0.3.0+dfsg/debian/control roc-toolkit-0.3.0+dfsg/debian/control
--- roc-toolkit-0.3.0+dfsg/debian/control 2023-12-02 09:58:05.000000000 +0100
+++ roc-toolkit-0.3.0+dfsg/debian/control 2023-12-12 21:03:29.000000000 +0100
@@ -5,6 +5,7 @@
Uploaders: Dylan Aïssi <[email protected]>
Build-Depends: debhelper-compat (= 13),
gengetopt,
+ libcpputest-dev,
libpulse-dev,
libsox-dev,
libspeexdsp-dev,
diff -Nru roc-toolkit-0.3.0+dfsg/debian/rules roc-toolkit-0.3.0+dfsg/debian/rules
--- roc-toolkit-0.3.0+dfsg/debian/rules 2023-12-02 09:58:05.000000000 +0100
+++ roc-toolkit-0.3.0+dfsg/debian/rules 2023-12-12 21:03:29.000000000 +0100
@@ -2,7 +2,7 @@
export DEB_BUILD_MAINT_OPTIONS=hardening=+all
-SCONS_BUILD_FLAGS = --libdir=/usr/lib/$(DEB_HOST_MULTIARCH) --disable-openfec
+SCONS_BUILD_FLAGS = --libdir=/usr/lib/$(DEB_HOST_MULTIARCH) --disable-openfec --enable-tests
ifneq (,$(filter alpha hurd-amd64 hurd-i386 m68k sparc64 x32,$(DEB_HOST_ARCH)))
SCONS_BUILD_FLAGS += --disable-libunwind
@@ -14,5 +14,8 @@
override_dh_auto_build:
scons ${SCONS_BUILD_FLAGS}
+override_dh_auto_test:
+ scons ${SCONS_BUILD_FLAGS} test/roc_core
+
override_dh_auto_install:
scons ${SCONS_BUILD_FLAGS} install DESTDIR=debian/tmp
--- End Message ---
--- Begin Message ---
Source: roc-toolkit
Source-Version: 0.3.0+dfsg-5
Done: Dylan Aïssi <[email protected]>
We believe that the bug you reported is fixed in the latest version of
roc-toolkit, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Dylan Aïssi <[email protected]> (supplier of updated roc-toolkit package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Wed, 13 Dec 2023 21:37:47 +0100
Source: roc-toolkit
Architecture: source
Version: 0.3.0+dfsg-5
Distribution: unstable
Urgency: medium
Maintainer: Debian Multimedia Maintainers <[email protected]>
Changed-By: Dylan Aïssi <[email protected]>
Closes: 1058582
Changes:
roc-toolkit (0.3.0+dfsg-5) unstable; urgency=medium
.
[ Sebastien Bacher ]
* Enable build tests (Closes: #1058582)
* Add libcpputest-dev in Build-Deps
Checksums-Sha1:
6f7f1db820268964fc71459582be5662cee45d84 2268 roc-toolkit_0.3.0+dfsg-5.dsc
8a0740aa5dccfcffd1f337936cf75060b3cae59b 2792
roc-toolkit_0.3.0+dfsg-5.debian.tar.xz
50d61a088b04eb571a8fbf68efe520470feae23d 10123
roc-toolkit_0.3.0+dfsg-5_amd64.buildinfo
Checksums-Sha256:
bd2e1a51a38a1ba08e5bcce3f9dd50dab3cd4b844531b97f664bc418d3c02e59 2268
roc-toolkit_0.3.0+dfsg-5.dsc
cf315d29e04ad0c76a0793f09c09a8aff3f94c82716b57b62de6dba5c2e3ad67 2792
roc-toolkit_0.3.0+dfsg-5.debian.tar.xz
098cf6be2e54d4a3d2d8542e86d89d955fbe6fd8fd582974d45c2aed454d690d 10123
roc-toolkit_0.3.0+dfsg-5_amd64.buildinfo
Files:
55ee973ad891d630ddfc03aaba09a00a 2268 sound optional
roc-toolkit_0.3.0+dfsg-5.dsc
40c558378a3da9c061bece24fec190ed 2792 sound optional
roc-toolkit_0.3.0+dfsg-5.debian.tar.xz
27fd765941991be7fc51587301263207 10123 sound optional
roc-toolkit_0.3.0+dfsg-5_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEEmjwHvQbeL0FugTpdYS7xYT4FD1QFAmV6FvYACgkQYS7xYT4F
D1ThZg/+NTmMoKmUSXS023KJFtKVp+5Tsc+1dBiHcmXWNT28DS5lrpVPn+buCjjy
EMOKrHXzHVOMLZ9A/I53H6x1ZuZXYiolXwgdCoPFeergFgu73FVUNmXWfoc/lXg/
Wq80AGdaNzxscXyNMwrXNHhWQlC+bbPumYnqaHv8T4oRrHY92Dot8w0rq+AKOzVP
G8RpNRXTnpx+mHYeMUl11V+0enQjQEVwgxlpInWSad/RsjtOr1xJQ+6u0bSRyF/n
v4s5KExV5qytK70sOf8tM17Xmj59DgJvTWU/nIOE0GIBPtBSdQE0PW2gainfShLg
ueJP0sanOqfJuD9Ozr+8MYltpNDMupSkowIRUCzi5OWDejK4nYth5j41OZLX2Axy
zBAarnDuOSQofnWdQZ3knbQPo934PDCSzfBA4q9pb0N9be4K/2GNUlNs+za4xyqA
KRh1W0B3fb4XKekGULFIsefwHxjm2afkEotE22OsAvtr8rrJB84pOvbusbgx7GFI
PgIBH3uW17I1XjNqtxsAzeBQD/HdyewyLnNeMhku1bEg408UDDj9ze2twgef/SlO
j6zx8iOPFuvAQcYQAPzuda1a9/CPYaQ6j4GT1TqXatTWZmpxjj/WaD4R5qx5iw8Z
ztbr22CzZ6NJyGUUGPsiniGCXo5vazQe5aG4QSw38nOnG3i66C0=
=0Nkl
-----END PGP SIGNATURE-----
--- End Message ---
