[patch] please fix invalid envelope-from in nmadvocate.php (was: Re: problem with email sent by Advocate Page on https://nm.debian.org/)

[Joost van Baal]

Hi,

In merkel:/org/nm.debian.org/wml/newmaint/nmadvocate.php, please change

 mail("[EMAIL PROTECTED]", "Advocate key for $forename $surname
  <$aemail>", $body, $headers);

in:

 mail("[EMAIL PROTECTED]", "Advocate key for $forename $surname
  <$aemail>", $body, $headers, "[EMAIL PROTECTED]");

or, if www-data is not an Exim trusted user, in:

 mail("[EMAIL PROTECTED]", "Advocate key for $forename $surname
  <$aemail>", $body, $headers, "-f<>");

.  This change would make sure the envelope-from address used in sent
mail is valid.  Currently, it's [EMAIL PROTECTED] which is
invalid.  Using an invalid From causes bounces to get lost.
Furthermore, it triggers some anti-spam checks which will lead to
undelivered mail.  (I myself suffered from that.)

Thanks, Bye,

Joost

signature.asc
Description: Digital signature