On Wed, Jul 19, 2006 at 11:26:25PM +0200, Stefano Zacchiroli wrote: > On Wed, Jul 19, 2006 at 04:35:20PM -0400, Eric Cooper wrote: > > I'd appreciate a sponsored upload; thanks. > > ATM it is not lintian clean: > > lintian > /local/zack/pkg-ocaml-maint/trunk/packages/ocaml-sha1/build-area/ocaml-sha1_0.4-1_i386.changes > E: ocaml-sha1 source: package-lacks-versioned-build-depends-on-debhelper 5 > > Please fix it.
Thanks for catching that; I guess I ran lintian on the binary but not the source package. > I also see your ml.dpatch rename upstream types in the Sha1 > module. Why you do that? In general it seems to be a bad idea > diverging from upstream naming convention, especially when touching > an interface since it will break .cmi compatibility. Are you in > touch with upstream or something else which justifies such a change? I thought it would be a good idea to follow the style of the existing Digest (MD5) interface in the standard library, but I will defer to the upstream author, as you suggest. -- Eric Cooper e c c @ c m u . e d u -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
